Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Paths #69

Closed
wvdvegt opened this issue May 11, 2017 · 3 comments
Closed

Data Paths #69

wvdvegt opened this issue May 11, 2017 · 3 comments

Comments

@wvdvegt
Copy link

wvdvegt commented May 11, 2017

Hi

If you're interested: I've updated your nice program so it puts all files in the roaming directory (a small piece was present, but I rewrote all filename strings to use Path.Combine() to get rid of any path separator issues).

Due to the buttons not showing I was not be able to run&check the citadel fitting dialog.

At the moment of writing the updater itself is not working (I did not check this separate project out yet).

I also changed the Ignore Minerals checkbox to be treestate so you can ignore all minerals or only high-sec mineable ones.

@wvdvegt
Copy link
Author

wvdvegt commented May 15, 2017

FYI I added further support fit treestate ignore minerals in the manufacturing tab, so it's possible to ignore high-sec minerals in calculations there too.

@Zifrian
Copy link
Member

Zifrian commented May 29, 2018

I couldn't get the pull request to work but looked through your code. I had to do a bit of work to get it to use the roaming folder but I did for the msi version of the installer. For binaries, I just let the user put them where they want and they can deal with the permissions. I'll look at the other changes you made later.

@Zifrian
Copy link
Member

Zifrian commented Nov 18, 2018

I implemented all the changes except the tri-state check for minerals. I'm going to re-look at that whole system anyway.

Rest of the changes I accepted.

@Zifrian Zifrian closed this as completed Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants