Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix BASE_URL to point to official api #11

Merged
merged 2 commits into from
Nov 6, 2017
Merged

fix BASE_URL to point to official api #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2da5e7
fix BASE_URL to point to official api
tj Nov 5, 2017
2efcd46
test: update snap
evenchange4 Nov 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/__tests__/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ describe('App Integration Test', () => {
repo: 'test',
});
expect(mockGitHubAPI.issues.edit).toHaveBeenCalledWith({
body: `[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option1)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option1/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option%202)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option%202/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option%203)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option%203/vote)`,
body: `[![](https://api.gh-polls.com/poll/ID/Option1)](https://api.gh-polls.com/poll/ID/Option1/vote)
[![](https://api.gh-polls.com/poll/ID/Option%202)](https://api.gh-polls.com/poll/ID/Option%202/vote)
[![](https://api.gh-polls.com/poll/ID/Option%203)](https://api.gh-polls.com/poll/ID/Option%203/vote)`,
number: 1234,
owner: 'evenchange4',
repo: 'test',
Expand All @@ -51,9 +51,9 @@ describe('App Integration Test', () => {

expect(mockGitHubAPI.issues.addLabels).not.toHaveBeenCalled();
expect(mockGitHubAPI.issues.edit).toHaveBeenCalledWith({
body: `[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option4)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option4/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option%205)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option%205/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option%206)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/Option%206/vote)`,
body: `[![](https://api.gh-polls.com/poll/ID/Option4)](https://api.gh-polls.com/poll/ID/Option4/vote)
[![](https://api.gh-polls.com/poll/ID/Option%205)](https://api.gh-polls.com/poll/ID/Option%205/vote)
[![](https://api.gh-polls.com/poll/ID/Option%206)](https://api.gh-polls.com/poll/ID/Option%206/vote)`,
number: 1234,
owner: 'evenchange4',
repo: 'test',
Expand Down
12 changes: 6 additions & 6 deletions src/__tests__/listener.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ it('should handle addPollListener', async () => {

expect(mockGitHubAPI.issues.edit).toHaveBeenCalledWith({
body: `H1H3
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/1)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/1/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/2)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/2/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/3)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/3/vote)`,
[![](https://api.gh-polls.com/poll/ID/1)](https://api.gh-polls.com/poll/ID/1/vote)
[![](https://api.gh-polls.com/poll/ID/2)](https://api.gh-polls.com/poll/ID/2/vote)
[![](https://api.gh-polls.com/poll/ID/3)](https://api.gh-polls.com/poll/ID/3/vote)`,
});
});

Expand All @@ -60,9 +60,9 @@ it('should not perform addLabels action when there is one', async () => {
expect(mockGitHubAPI.issues.addLabels).not.toHaveBeenCalled();
expect(mockGitHubAPI.issues.edit).toHaveBeenCalledWith({
body: `H1H3
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/1)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/1/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/2)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/2/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/3)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/3/vote)`,
[![](https://api.gh-polls.com/poll/ID/1)](https://api.gh-polls.com/poll/ID/1/vote)
[![](https://api.gh-polls.com/poll/ID/2)](https://api.gh-polls.com/poll/ID/2/vote)
[![](https://api.gh-polls.com/poll/ID/3)](https://api.gh-polls.com/poll/ID/3/vote)`,
});
});

Expand Down
2 changes: 1 addition & 1 deletion src/utils/__tests__/__snapshots__/config.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`should return config 1`] = `
Object {
"BASE_URL": "https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod",
"BASE_URL": "https://api.gh-polls.com",
"LABEL": "Polls",
}
`;
8 changes: 4 additions & 4 deletions src/utils/__tests__/__snapshots__/toMarkdown.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`should return markdown 1`] = `
"[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/MOCK_ID/1)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/MOCK_ID/1/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/MOCK_ID/2)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/MOCK_ID/2/vote)
[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/MOCK_ID/3)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/MOCK_ID/3/vote)"
"[![](https://api.gh-polls.com/poll/MOCK_ID/1)](https://api.gh-polls.com/poll/MOCK_ID/1/vote)
[![](https://api.gh-polls.com/poll/MOCK_ID/2)](https://api.gh-polls.com/poll/MOCK_ID/2/vote)
[![](https://api.gh-polls.com/poll/MOCK_ID/3)](https://api.gh-polls.com/poll/MOCK_ID/3/vote)"
`;

exports[`should return markdown with only one option 1`] = `"[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/MOCK_ID/1)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/MOCK_ID/1/vote)"`;
exports[`should return markdown with only one option 1`] = `"[![](https://api.gh-polls.com/poll/MOCK_ID/1)](https://api.gh-polls.com/poll/MOCK_ID/1/vote)"`;
3 changes: 1 addition & 2 deletions src/utils/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
/**
* ref: https://github.com/srph/gh-polls-web/blob/master/src/config.js
*/
const BASE_URL /* : string */ =
'https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod';
const BASE_URL /* : string */ = 'https://api.gh-polls.com';
const LABEL /* : string */ = 'Polls';

module.exports = {
Expand Down