Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you need mandrill as a runtime dependency? #2

Closed
ssaunier opened this issue Apr 26, 2013 · 5 comments
Closed

Why do you need mandrill as a runtime dependency? #2

ssaunier opened this issue Apr 26, 2013 · 5 comments

Comments

@ssaunier
Copy link

Can't figure out from looking at the code, sorry...

@tardate
Copy link
Member

tardate commented Apr 27, 2013

I think you might be right - the mandrill gem isn't really required. I think I must have added it during early experiments but never removed when the need for it was no longer there.

Does it cause you any problems?

@ssaunier
Copy link
Author

Hi @tardate,

The thing is, I was trying to figure my way through the 5 gems about Mandrill https://rubygems.org/search?utf8=%E2%9C%93&query=mandrill

Turns out tatemae-consultancy/mandrill works great (and this is the gem you require_dependency), but the guys are telling me that they migrated to use the mailchimp/mailchimp-gem (https://github.com/tatemae-consultancy/mandrill/pull/3#issuecomment-17086032) which makes sense.

The official mailchimp gem (embedding integration with the Mailchimp API) does not support Webhooks like yours greatly do, so the idea would be that your gem addresses only the webhooks (and advertise it more clearly by maybe renaming it to mailchimp-webhook), and just extend the module Mailchimp::Mandrill ?

Just my 2 cents.

Thanks !

@tardate
Copy link
Member

tardate commented Apr 28, 2013

That's a very good suggestion @ssaunier, and thanks for the update on the mailchimp gem status.

I think what I'll do for now is just drop the mailchimp gem requirement.

@ssaunier
Copy link
Author

Sounds like a plan! Do you have an ETA for the 0.0.4? Do you need help? Thanks!

tardate added a commit that referenced this issue Apr 29, 2013
@tardate
Copy link
Member

tardate commented Apr 29, 2013

Thanks for the offer of help @ssaunier but it turned out to be a one-liner after all - didn't find any hidden complexities after making the change. I'll push a new gem version as soon as tests confirmed green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants