Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres connect with url string #254

Merged
merged 3 commits into from
May 1, 2021
Merged

Postgres connect with url string #254

merged 3 commits into from
May 1, 2021

Conversation

borsemayur2
Copy link
Contributor

No description provided.

@borsemayur2
Copy link
Contributor Author

Related to #253

eveningkid
eveningkid requested changes May 1, 2021
View reviewed changes
Copy link
Owner

@eveningkid eveningkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mayur,

Thank you for contributing to the project :)

I left you a note, I'll wait for your reply.

Have a great day

lib/connectors/postgres-connector.ts Outdated Show resolved Hide resolved
@borsemayur2 borsemayur2 marked this pull request as ready for review May 1, 2021 12:17
eveningkid
eveningkid approved these changes May 1, 2021
View reviewed changes
Copy link
Owner

@eveningkid eveningkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, Mayur :)

Thanks, will merge now and make a new release!

Have a great day

@eveningkid eveningkid merged commit 18a6073 into eveningkid:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eveningkid eveningkid eveningkid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@borsemayur2 @eveningkid