Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Testing #104

Closed
aliceafterall opened this issue Oct 2, 2017 · 1 comment
Closed

Improve Testing #104

aliceafterall opened this issue Oct 2, 2017 · 1 comment
Labels
develop developer task enhancement high priority

Comments

@aliceafterall
Copy link
Member

aliceafterall commented Oct 2, 2017 •
edited by Griatch

Ainneve's tests fail under 0.7, with the PR I made. Other than the unittests, everything works - the commands tested by the failing unittests work correctly in game.

Overall, improving coverage, setting up coveralls, and fixing up tests to be more readable and better commented is a very important step to get Ainneve back up and running.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@aliceafterall
Copy link
Member Author

The recent push to develop fixed our testing woes - use the latest version of Evennia and the develop branch of Ainneve, and our tests work again. We still need to improve them, especially readability wise.

In a lot of our tests we directly check hardcoded strings - perhaps we can work on that next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
develop developer task enhancement high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aliceafterall @InspectorCaracal