Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] XYZ Contrib Attempted Double Spawning #3475

Closed
jaborsh opened this issue Apr 2, 2024 · 4 comments
Closed

[BUG] XYZ Contrib Attempted Double Spawning #3475

jaborsh opened this issue Apr 2, 2024 · 4 comments
Labels
bug An actual error or unwanted behavior.

Comments

@jaborsh
Copy link
Contributor

jaborsh commented Apr 2, 2024

Describe the bug

XYZ spawner will attempt to re-spawn an already spawned room due to the spawner checking for XYZRoom typeclass explicitly instead of anything that inherits from XYZRoom.

From @Griatch: "The trick here is that the spawner needs to check for the full family of XYZRoom (including its children) to determine if it exists or not. So - this looks to be an issue in the spawner itself.

To Reproduce

Steps to reproduce the behavior:

  1. Set spawn room typeclass in node and in prototypes
  2. Attempt spawn
  3. See error

Expected behavior

After entry is created, spawner should seek to update instead of re-spawning something already spawned.

@jaborsh jaborsh added bug An actual error or unwanted behavior. needs-triage Yet to be looked at and verified as an a real issue/feature that could be worked on labels Apr 2, 2024
@Griatch
Copy link
Member

Griatch commented Apr 4, 2024

@jaborsh The hunch I had about this didn't pan out, looks like the system is searching for the children of XYZRooms 🤔

@jaborsh
Copy link
Contributor Author

jaborsh commented Apr 7, 2024

@jaborsh The hunch I had about this didn't pan out, looks like the system is searching for the children of XYZRooms 🤔

I will try to reproduce using a fresh environment if you haven't done so already. It's possible there's some miscommunication happening on my end since I have the grid spawn/update at_server_start

@Griatch Griatch removed the needs-triage Yet to be looked at and verified as an a real issue/feature that could be worked on label Apr 7, 2024
@Griatch
Copy link
Member

Griatch commented Apr 7, 2024

@jaborsh If you can give some simple example code to reliably reproduce, that would help 👍

@jaborsh
Copy link
Contributor Author

jaborsh commented May 6, 2024

Marking this as closed. @InspectorCaracal believes the issue was due to calling spawn() twice, once with the intention to initialize and again with the intention to update, which is already functional with the built-in prototype system.

@jaborsh jaborsh closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An actual error or unwanted behavior.
Projects
None yet
Development

No branches or pull requests

2 participants