Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more problems with @find #574

Closed
aegarpyke opened this issue Sep 9, 2014 · 1 comment
Closed

more problems with @find #574

aegarpyke opened this issue Sep 9, 2014 · 1 comment

Comments

@aegarpyke
Copy link

Install fresh Evennia according to the Getting Started guide.

Searching by Alias

@tunnel w = Hall of Testing;hall#1
@find hall

One Match(#1-#9):
Hall of Testing(#7) - src.objects.objects.Room

Expected.

@find hall#

Match(#1-#9):
No matches found for 'hall#'

Unexpected. Should match the room's alias 'hall#1' like below.

@find hall#1

One Match(#1-#9):
Hall of Testing(#7) - src.objects.objects.Room

Expected.

@find #1

Match(#1-#9):
Aegar(#1) - src.objects.objects.Character

Unexpected. Should this include the partial match for the 'hall#1' alias?

Searching by alias with multiple rooms

@tunnel s = Hall of Testing;hall#2
@find hall

2 Matches(#1-#12):
Hall of Testing(#7) - src.objects.objects.Room
Hall of Testing(#10) - src.objects.objects.Room

Expected.

@find hall#

Match(#1-#12):
No matches found for 'hall#'

Unexpected. Should return all partial matched aliases with 'hall#'

Room switch returns a non-room

@find/room #1

Match(#1-#9):
Aegar(#1) - src.objects.objects.Character

Unexpected. Should only return rooms.

@duartecordeiro
Copy link
Contributor

@find hall#
@find is searching for keys that start with findtext and for aliases that match findtext. So hall# doesnt work and hall#1 works. Fixing it.

@find #1
This is the expected behavior. You are searching for object ID 1.

@find/room #1
This reflects a problem with arguments parsing. If searching for a object id or player, evennia now ignores the filters. We have 3 possible solutions:

  1. filter results: @find/room #1 would return no results .
  2. thrown error on the filter: @find/room #1 would say something like: Error: Searching for object id, filters not allowed .
  3. Don't filter and let the user know that we're not filtering:
@find/room #1
Match(#1-#9): 
Aegar(#1) - src.objects.objects.Character
(Filter by room ignored while searching for ID - read help for more information)

I think we should opt for the later.

Griatch added a commit that referenced this issue Sep 15, 2014
… alias-query aware of low-high dbref limits and changed room/exit/char filters to use inherits_from instead of dumbly assuming e.g. a room being an object with no location. Also restructured the code a little.
@Griatch Griatch closed this as completed Sep 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants