Put in check for maximum character size in input strings #1137
Conversation
…set with settings.MAX_CHAR_LIMIT.
| # limit, we stop them and send a message. Set to None by default. To | ||
| # change it, just set it to a number of characters - ie, 6000 to be | ||
| # roughly two pages of text. | ||
| MAX_CHAR_LIMIT = None |
There was a problem hiding this comment.
I think it may be a reasonable thing to actually set a sane default max here - it's good for people that don't bother with the settings. People can always up the limit manually later if they think it's limiting. I don't know what the max would be though - it would need to be a value you rarely hit yet not so large you run into slowdowns. 6000 sounds like a lot to me, but maybe it's not ...?
| @@ -18,9 +18,11 @@ | |||
| # throttles | |||
| _MAX_CONNECTION_RATE = float(settings.MAX_CONNECTION_RATE) | |||
| _MAX_COMMAND_RATE = float(settings.MAX_COMMAND_RATE) | |||
| _MAX_CHAR_LIMIT = settings.MAX_CHAR_LIMIT | |||
There was a problem hiding this comment.
Better convert this to an int() here, so eventual unit errors in the settings file get caught early (doing > operations can have some unexpected results when mixing types).
|
6000 is just around the edge of the largest things I've seen people write that aren't just trying to mess with people - ascii art for item descriptions, generally speaking. When I start to see clients die is when it's probably like an order of magnitude larger than that, though that's just a ballpark estimate. If you think a smaller value would be more sane as a default, by all means! It's just what I would land on myself. |
Brief overview of PR changes/additions
Just an optional setting, MAX_CHAR_LIMIT, that lets you specify the maximum length of any string passed on from the portalsessionhandler to the server, to prevent people from obnoxiously spamming and the like.
Motivation for adding to Evennia
Just a little optional anti-troll protection.
Other info (issues closed, discussion etc)
I made the default None, which leaves it uncapped, so current behavior is unaffected.