-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend CRUD enhancements (character/account creation and management) #1671
Conversation
… processor for it.
I meant to update to the latest stable! It's a good idea to ensure nothing broke due to this update, so I'll test that out ASAP. |
…e/manage characters, and character quickselect.
To initiate the password reset process for your {{ user.get_username }} {{ site_name }} account, | ||
click the link below: | ||
|
||
{{ protocol }}://{{ domain }}{% url 'password_reset_confirm' uidb64=uid token=token %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, domain is set to "example.com" per the default configuration of what appears to be the Django Sites framework. This should probably be resolved during evennia --init
but is beyond me to fix-- it also impacts the reverse "view on site" link in the Django admin (if get_absolute_url is implemented on the object in question).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, some very good improvements here. The style changes and more elaborate input for registering looks nice and professional! Interesting to offer a default example of online character-creation - I like it, but have given some comments so as to make it clear this is just that - an example (the more advanced and game-specific code rather belongs in a contrib or a wiki tutorial).
(Should also point out that I was looking through #533 and I think this may lay the groundwork but otherwise goes a little outside the frame of what that issue covers - this allows for account/character creation for the users themselves; #533 is more humble in that it aims to clean up and make the web-Admin more usable for creating Accounts and linking them to Characters/Attributes from the perspective of a staffer).
@strikaco Is this ready for re-review? |
No, not ready yet; the dropdown bug is still outstanding. |
Fixed the dropdown bug but still have some tidying up to do. Further updates as events warrant... |
…haracters list, and check for multisession mode compliance.
…ests. Converts index view to CBV.
So we now have a form-based character creation page, a character update page, a character management page, a character deletion page, ownership and lock checks for both, character puppeting on the website, a password change workflow, and unit tests for all website views. Everything works as far as I've thought to test it. I think that's enough changes for one PR... for all this entailed, I'm missing out on a lot of Hacktoberfest cred :\ @Griatch ready for you to tell me how much my documentation sucks :) |
…owser to character management page.
…istent with index.
… with rest of site.
The documentation of some of these functions is too sparse 😛 But this is great work, I think it's worth merging and resolve any remaining issues as they come along. Thanks for your hard work! |
Brief overview of PR changes/additions
Other info (issues closed, discussion etc)
Another notch towards #533