-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object URL references, named paths and pseudo-slugs #1674
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a0bed8f
Adds get_absolute_url() and get_admin_url() methods to DefaultObject,…
strikaco fc55f0f
Adds dynamic get_*_url() fields to DefaultObject and children and sta…
strikaco 7830f34
Makes lazy reversals not lazy; prevents errors from manifesting out o…
strikaco b37e3a8
Renames all URL methods to web_*, moves to TypedObject model.
strikaco a5b759c
Renames methods to web_get_* and fixes tests.
strikaco cfc8179
Merge branch 'develop' into smarturls
strikaco File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
from evennia.utils.test_resources import EvenniaTest | ||
|
||
class DefaultObjectTest(EvenniaTest): | ||
|
||
def test_urls(self): | ||
"Make sure objects are returning URLs" | ||
self.assertTrue(self.char1.get_absolute_url()) | ||
self.assertTrue('admin' in self.char1.web_get_admin_url()) | ||
|
||
self.assertTrue(self.room1.get_absolute_url()) | ||
self.assertTrue('admin' in self.room1.web_get_admin_url()) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
web_get_detail_url
not namedweb_absolute_url
ifget_absolute_url
is what django expects - would not that name (just addingweb_
) be more expected?