SIGNAL_ACCOUNT_POST_LOGIN_FAIL is now properly used. Added a CUSTOM_S… #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IGNALS event handler to signals.py
Griatch
requested changes
Nov 18, 2023
evennia/server/signals.py
Outdated
Comment on lines
95
to
97
| # Used as a generic event emitter. Use to make your own signals easily in one place! | ||
| SIGNALS_CUSTOM: dict[str, Signal] = defaultdict(Signal) | ||
|
|
There was a problem hiding this comment.
This could do with some example of how to use this.
Griatch
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
the SIGNAL_ACCOUNT_POST_LOGIN_FAIL signal wasn't being called anywhere, so that's been fixed.
A SIGNALS_CUSTOM object has been added to signals.py using a defaultdict to make for an easy event handler.
Motivation for adding to Evennia
Although I regret pushing for adding these signals all over the place (the custom variant using the defaultdict is a much more elegant approach), they ought to do what they say they do, so... fixing this oversight.
Other info (issues closed, discussion etc)