Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override example crafting recipes #3425

Merged
merged 3 commits into from Feb 24, 2024
Merged

Conversation

InspectorCaracal
Copy link
Contributor

Brief overview of PR changes/additions

Replaces the example recipes if you've set your own recipe modules, rather than forcing people's games to either include them or go out of their way to hack them back out.

Motivation for adding to Evennia

I need to not have these recipes in my game. >.>

@InspectorCaracal
Copy link
Contributor Author

I know this is not exactly kosher but I found another bug in the crafting contrib just now and decided it would be easier for everyone to put the fix in here rather than open another tiny PR, since they're both the same contrib.

Copy link
Member

@Griatch Griatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. Makes sense.

Also fine to add the bug-fix since it's a small one (hint: you can click on lines in your own PR and add line comments - very useful for explaining parts of your PR code you think the reviewer may wonder about).

@Griatch Griatch merged commit 772d4c2 into evennia:main Feb 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants