Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
The editor's range specification (n:n) returns at most two lines. This has been fixed.
Also, as part of this:
utils.value_is_integer(value)
has been added which returnsTrue
ifvalue
can be type-cast to an integer andFalse
otherwise. This is to allow checking for negative integers, whichstr.isdigit()
can't do.Motivation for adding to Evennia
Fix editor range specification.
Other info
Test buffer
Before
After
Changed unit test
This test expects the output "Flood filled lines 1-2." for a buffer containing only one line. After the fix the above command will return "Flood filled line 1.", which is correct. The test has been updated to look for the new output.