Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CounterTrait now checks for last_update before defaulting to current time. #3495

Merged
merged 1 commit into from Apr 7, 2024

Conversation

jaborsh
Copy link
Contributor

@jaborsh jaborsh commented Apr 7, 2024

Brief overview of PR changes/additions

@jaborsh jaborsh changed the title CounterTrait now checks for last_update before defaulting to current time. Resolves #3317 CounterTrait now checks for last_update before defaulting to current time. Apr 7, 2024
Copy link
Member

@Griatch Griatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks!

Note: This seems to be formatted to 78 character line width. Evennia uses 100 character line width (allowed by PEP8; see CODE_STYLE.md). I'll reformat that after merge, but linting like this makes it much harder to see what the actual functional change is, so best avoid doing so in a PR unless the reformat is the point of said PR :) )

@Griatch Griatch merged commit f84dde8 into evennia:main Apr 7, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants