Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix room creation showing room name instead of typeclass path #3499

Merged
merged 1 commit into from Apr 27, 2024
Merged

Fix room creation showing room name instead of typeclass path #3499

merged 1 commit into from Apr 27, 2024

Conversation

chiizujin
Copy link
Contributor

Brief overview of PR changes/additions

When rooms are created in-game with dig or tunnel, the feedback message shows the room's name/key instead of its typeclass path.

Motivation for adding to Evennia

Bug fix.

Other info

Before

>dig cave1
Created room cave1(#3) of type cave1.

After

>dig cave2
Created room cave2(#4) of type typeclasses.rooms.Room.

@chiizujin
Copy link
Contributor Author

I'm making the assumption that this is what is intended.

Griatch
Griatch approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@Griatch Griatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this makes me wonder why this is not caught by a unit test 🤔

@Griatch Griatch merged commit dcc4dce into evennia:main Apr 27, 2024
8 of 10 checks passed
@chiizujin chiizujin deleted the room_create branch April 28, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Griatch Griatch Griatch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chiizujin @Griatch