Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traceback when setting prototype parent #3506

Merged
merged 1 commit into from Apr 27, 2024

Conversation

chiizujin
Copy link
Contributor

Brief overview of PR changes/additions

When setting a prototype parent in the prototype wizard, an exception is raised in the console. No feedback is given in the wizard itself other than [No prototype_parent set] being displayed for the current parent.

This fixes the exception, allowing the parent to be set: Selected prototype parent test.

Motivation for adding to Evennia

Bug fix.

Other info

Exception:

Traceback (most recent call last):
  File "/home/chiizujin/Data/Source/Python/Evennia-contrib/evennia/evennia/commands/cmdhandler.py", line 754, in cmdhandler
    raise ExecSystemCommand(syscmd, sysarg)
evennia.commands.cmdhandler.ExecSystemCommand: (<evennia.utils.evmenu.CmdEvMenuNode object at 0x7f8a2cc99a50>, '1')
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/chiizujin/Data/Source/Python/Evennia-contrib/evennia/evennia/utils/evmenu.py", line 1359, in _select_parser
     return select(caller, selection, **kwargs)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 TypeError: _prototype_parent_select() got an unexpected keyword argument '_current_nodename'
 Error in EvMenu.list_node decorator:
   select-callable: <function _prototype_parent_select at 0x7f8a2cefa660>
   with args: (Chiizujintest, ['test'], {'_current_nodename': 'node_prototype_parent'}) raised exception.

@Griatch Griatch merged commit 4e033f0 into evennia:main Apr 27, 2024
7 of 10 checks passed
@chiizujin chiizujin deleted the proto_parent branch April 28, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants