Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GlobalScriptsContainer scripts attribute reference #3518

Merged
merged 1 commit into from Apr 27, 2024

Conversation

InspectorCaracal
Copy link
Contributor

Brief overview of PR changes/additions

There is no scripts attribute on the GlobalScriptsContainer class; the correct attribute is loaded_data, as is done in the base Container class. As a result, attempting to do GLOBAL_SCRIPTS.all() currently results in the following traceback:

  File "./evennia/evennia/utils/containers.py", line 247, in all
    return self.scripts.values()
           ^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'values'

Motivation for adding to Evennia

Bug fixing

Other info (issues closed, discussion etc)

Reported on Discord

@Griatch Griatch merged commit 698b65f into evennia:main Apr 27, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants