Support full capitalization in GMCP commands #3521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Changes the GMCP command encoding to only run capitalize() on command parts that are not fully uppercase.
Motivation for adding to Evennia
A previous conversation on Discord identified the current GMCP encoding's command capitalization as somewhat lacking, based on their own previous use of GMCP in other MUD libraries. Additionally, today a specific use-case arose that is currently impossible: sending a Mudlet package install command, as per the Mudlet docs - it requires the ability to send a fully capitalized command section,
Client.GUI
.Other info (issues closed, discussion etc)
I'm not extremely familiar with the specifications of the GMCP protocol, so I wrote this under the assumption that mixed-case command parts are not allowed.