[Components] Fix components improperly setting _fields #3537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Since the last refactoring, the
_fields
in components is getting improperly set.This fix modifies the metaclass constructor to ensure that the dict is properly set for each component once.
I have added a test and tested locally, I think this fix should work.
It's likely not the most elegant but since lyrewyn told me about the issue and I don't know how long it will take me
to refine, so I am opening as is for now.
Motivation for adding to Evennia
Bugfix
Other info (issues closed, discussion etc)