Fixed global eslint and tsconfig #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They seem not to be needed when using npm workspaces, as it should add symlinks
The "funny thing" was that the issue was with not wrapping pattern with ''🤦. See eslint/eslint#13896 (comment)
oskardudycz
added
enhancement
…ative resolution happy
oskardudycz
changed the title
oskardudycz
commented
Mar 7, 2024
| @@ -11,12 +11,12 @@ | |||
| "plugin:@typescript-eslint/recommended-requiring-type-checking", | |||
| "plugin:prettier/recommended" | |||
| ], | |||
| "ignorePatterns": ["dist/", "lib/"], | |||
| "ignorePatterns": ["**/dist/", "**/lib/"], | |||
There was a problem hiding this comment.
To ignore nested folders inside packages.
oskardudycz
commented
Mar 7, 2024
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "extends": "./tsconfig.shared.json", | |||
| "include": ["./packages/**/*.ts", "./docs/**/*.ts", "./tsup.config.ts"], | |||
There was a problem hiding this comment.
Eslint seems not to deal well with the project references. But they're needed to correctly resolve correctly dependencies by TypeScript. That's why, as a workaround, I added a dedicated file that removes dependencies but adds "./packages/**/*.ts". It's weird, but it works...
oskardudycz
commented
Mar 7, 2024
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Those dummy files are needed for vscode eslint plugin, as it runs eslint config locally for packages. And as in the file, we have a reference for tsconfig.eslint.json. Then if it won't find such a file in the local package folder, then it will cry out loud and doesn't highlight eslint errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to configure a separate config for eslint, as it doesn't deal well with the TypeScript project references. Also, it wasn't checking correctly the eslint settings, as eslint requires wrapping global pattern in
''to be passed as a parameter instead of taken as the shell pattern. 🤦Updated also pipeline to run ts build before linting to have correctly resolved dependencies between packages and non-package code.
Fixes #18.