Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrayPropItemTypeMap should be indexed with a specialKey #20

Conversation

arnedesmedt
Copy link
Contributor

I don't know if this should be merged into master. If not, let me know.

The problem was that special key support was not working for arrayPropItemTypeMap.

In the toArray function of ImmutableRecordLogic the key of arrayPropItemTypeMap should be the propertyName (the one that is converted)
while in the fromArray function the key of arrayPropItemTypeMap should be the given key (the one that is not converted).

So I changed this that the converted key is also used in the fromArray function for arrayPropItemTypeMap.

I also tested this functionality in an existing test.

@arnedesmedt
Copy link
Contributor Author

@codeliner or @sandrokeil any ideas on this one?

@codeliner
Copy link
Contributor

@sandrokeil I think we can merge, or?

@codeliner codeliner requested a review from sandrokeil May 3, 2022 07:14
@codeliner
Copy link
Contributor

ok, we checked it internally and it's indeed a bug that should be fixed. Good catch @arnedesmedt and thx for PR!

@codeliner codeliner merged commit 3db2352 into event-engine:master May 5, 2022
@arnedesmedt
Copy link
Contributor Author

It's a pleasure! Thx for the great event-engine packages you made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants