Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract filter processing logic to a seperate class #21

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Extract filter processing logic to a seperate class #21

merged 1 commit into from
Apr 3, 2022

Conversation

zluiten
Copy link
Contributor

@zluiten zluiten commented Feb 23, 2021

See #20

@zluiten zluiten force-pushed the feature/extract-filter-processor branch 3 times, most recently from 8b451a2 to 7bc71d9 Compare February 24, 2021 09:49
@zluiten
Copy link
Contributor Author

zluiten commented Feb 24, 2021 •
edited
Loading

I have reverted most cs changes to make the change more clear. The unit tests succeed.

Should we add a .travis.yml file? I tried to use the one from https://github.com/event-engine/php-engine but it seem to require some more work.

codeliner
codeliner requested changes Mar 5, 2021
View reviewed changes
src/Filter/FilterProcessor.php Outdated Show resolved Hide resolved
@codeliner
Copy link
Contributor

yeah, travis config should be added, but let's do it in another PR. I usually run unit tests before a release.

@zluiten zluiten force-pushed the feature/extract-filter-processor branch from 7bc71d9 to 6c8d0e5 Compare April 2, 2022 11:45
@zluiten zluiten requested a review from codeliner April 2, 2022 11:47
@zluiten zluiten force-pushed the feature/extract-filter-processor branch from 6c8d0e5 to 5a3fcc1 Compare April 2, 2022 11:50
codeliner
codeliner requested changes Apr 3, 2022
View reviewed changes
src/Filter/FilterProcessor.php Outdated Show resolved Hide resolved
@zluiten zluiten force-pushed the feature/extract-filter-processor branch from 5a3fcc1 to 1937cc1 Compare April 3, 2022 10:38
@zluiten zluiten requested a review from codeliner April 3, 2022 10:41
@codeliner codeliner merged commit 2c7daec into event-engine:master Apr 3, 2022
@codeliner
Copy link
Contributor

👍 thank you @Netiul

@codeliner codeliner mentioned this pull request Apr 3, 2022
Closed
@zluiten
Copy link
Contributor Author

zluiten commented Apr 3, 2022

You're welcome @codeliner Sorry for the long waiting... Time flies!

@zluiten zluiten deleted the feature/extract-filter-processor branch April 3, 2022 19:26
@zluiten zluiten mentioned this pull request Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeliner codeliner codeliner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zluiten @codeliner