Fix user.owned_events example in readme #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the readme to remove references to the deprecated `user.owned_events`, replaces with examples of how to fetch organization events
jeff-eb
suggested changes
May 18, 2020
| @@ -5,6 +5,7 @@ class User < Resource | |||
| # NOTE: This name is pretty legacy. We should consider renaming | |||
| # to "orders" to normalize things. | |||
| has_many :owned_event_orders, object_class: 'Order', key: :orders | |||
| has_many :organizations, object_class: 'Organization', key: :organizations | |||
There was a problem hiding this comment.
This looks good but is untested functionality. If you could add tests to cover this we can approve and merge it. You'll find examples of tests for associated relationships in a handful of places like https://github.com/eventbrite/eventbrite-sdk-ruby/blob/master/spec/eventbrite_sdk/organization_spec.rb#L25
kenxfoster
force-pushed
the
user-organization-patch
branch
2 times, most recently
from
9d548fd
to
b401e70
Compare
|
As noted in #46 the examples in the README don't work, so the library is not usable for really basic tasks (just want to list all the events owned by a user). This PR looks like its intended to fix that, but is stuck in limbo? |
|
I have encountered the same problem and happy to lend a hand to continue working on this PR and fix the problem if the owner doesn't have time to tend to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme contains example of how to fetch
user.owned_events, but this is recently deprecated and no longer returns event. This PR updates the docs to demo how to fetch events via organizations.