E2E default maximum tickets #1108

marlonhario · 2021-12-20T15:15:50Z

For this ticket:

E2E test for default maximum tickets allowed at default settings.

tn3rb · 2021-12-20T20:15:19Z

packages/e2e-tests/specs/admin/events/default-settings/defaultMaximumTickets.test.ts

+import { Goto, DefaultSettingsManager, EventsListSurfer, createNewEvent } from '@e2eUtils/admin';
+import { eventData } from '../../../shared/data';
+
+const defaultSettingsManager = new DefaultSettingsManager();


tn3rb · 2021-12-20T20:27:52Z

packages/e2e-tests/specs/admin/events/default-settings/defaultMaximumTickets.test.ts

+	// delete all events from view all events link
+	await eventsListSurfer.deleteAllEventsByLink('View All Events');
+	// delete all events from draft link
+	await eventsListSurfer.deleteAllEventsByLink('Draft');
+	// delete permanently all events at trash link
+	await eventsListSurfer.deleteAllPermanentlyFromTrash();


do we need t o delete all events to test the default max tickets?
i would think that would unnecessarily add to the time it takes to run tests.
if the issue is just for the sake of cleaning up after tests, then maybe that should be moved into the afterAll() function?
could even be extracted into a utility function like: deleteEventsAfterTest() or postTestEventCleanup() or ???

Yes sorry, I think this one is not needed.

tn3rb · 2021-12-20T20:31:51Z

packages/e2e-tests/specs/admin/events/default-settings/defaultMaximumTickets.test.ts

+	let countEvents: number;
+	it('Count view all events link for test starting', async () => {
+		// Get selected default status and return weither option value or innertext of the option
+		countEvents = await defaultSettingsManager.getViewCount('View All Events');
+		console.log({ countEvents });
+		// assert the current selected registration status
+		expect(countEvents).toBe(0);
+	});


similar to deleting events... do we need to count and verify zero events prior to testing the default max tickets?

Yes also this one is not needed sorry for that.

tn3rb · 2021-12-20T20:46:38Z

packages/e2e-tests/specs/admin/events/default-settings/defaultMaximumTickets.test.ts

+		const countEventsAfterCreatedNew = await defaultSettingsManager.getViewCount('View All Events');
+		const countAddedEvent = countEventsAfterCreatedNew - countEvents;
+		// assert the current selected registration status
+		expect(countEventsAfterCreatedNew).toBe(countAddedEvent + countEvents);


don't need to count anything for this test...
except... it might be good to verify that the event was created before proceeding,
so asserting that createNewEvent() succeeded would be good, but that can maybe be done within that function itself

tn3rb · 2021-12-20T20:50:30Z

packages/e2e-tests/specs/admin/events/default-settings/defaultMaximumTickets.test.ts

+	it('Create sample ticket', async () => {
+		// get the first event in trash
+		const firstItem = await defaultSettingsManager.getFirstListItem();
+		// got to "restore from trash" action link for the selected first event
+		const restoreLink = await defaultSettingsManager.getItemActionLinkByText(firstItem, 'Edit');
+		await page.goto(restoreLink);
+
+		// await Promise.all([page.waitForNavigation(), page.click('.ee-entity-list__footer button[type="button"]')]);
+		await page.click(
+			'#ee-event-editor .ee-entity-list__footer button[type="button"] span:has-text("Add New Ticket")'
+		);
+		await page.click('input[name="name"]');
+		await page.fill('input[name="name"]', 'Ticket sample name');
+		await page.fill('.public-DraftEditor-content', 'Ticket sample description');
+		await page.click('.ee-modal__footer span:has-text("Skip prices - assign dates")');
+		await page.click('#ee-ticket-assignments-manager-table-data-cell-row-0-col-1 button');
+		await page.click('button[type="submit"]');
+		console.log({ firstItem });
+
+		expect(0).toBe(0);
+	});


we don't need to create any tickets for this test.
Creating a new event shoud result in at least one default ticket getting added, but that still has nothing to do with what we need to test here. All we need to confirm is that setting the value of this input:

results in the correct value here on a newly created event:

EDTR:

Legacy Event Editor:

The code you added in this test may be useful somewhere else in another test, so maybe just copy it to a file somewhere on your local system for now (as opposed to just deleting it)

tn3rb

sry but this needs some refactoring.
it does not appear to be testing the correct functionality.
I think it might help if I create issues for each test ahead of time so that I can explain what each test needs to do and include screenshots if need be

tn3rb

Better but still not quite right.

The biggest issue is a misunderstanding about how default settings work.

Default settings, such as the "Default Maximum Tickets Allowed" are for configuring the initial values used when creating a new event. So the process needs to work like this:

go to the "Default Settings" tab in the Events admin
set "Default Maximum Tickets Allowed" option and click "Save"
go to Events Overview tab and click "Add New Event"
"Max Registrations per Transaction" value under "Registration Options" for the new event should match what was set in the first step.

The following will NOT work

go to Events Overview tab and click "Add New Event"
take note of the "Max Registrations per Transaction" value
go to the "Default Settings" tab in the Events admin
set "Default Maximum Tickets Allowed" option to something new and click "Save"
return to Events Overview tab, find previously created event in list and click to edit it
"Max Registrations per Transaction" value under "Registration Options" will be the SAME value it was when we first viewed it and NOT match the new value that was just set for the "Default Maximum Tickets Allowed" option

So these tests need to be slightly rearranged so that a new event is created AFTER the "Default Maximum Tickets Allowed" option has been set to a new value.

As well, plz note that you can use hard coded values for this option. So for example you could refactor the tests to work like this:

go to the "Default Settings" tab in the Events admin
set "Default Maximum Tickets Allowed" option to 7 and click "Save"
go to Events Overview tab
click "Add New Event"
verify that "Max Registrations per Transaction" value equals 7

tn3rb

aaaaaalllllllllllmost there...

just have a few more tweaks that need to be done, but is otherwise looking really good

tn3rb · 2022-01-03T17:36:17Z

packages/e2e-tests/specs/admin/events/default-settings/defaultMaximumTickets.test.ts

+		// get added number
+		const getAdded = Number(checkEDTRMaxTicket) - Number(getDefaultMaxBeforeChange);
+		// assert maximum ticket allowed at EDTR
+		expect(Number(checkEDTRMaxTicket)).toBe(getAdded + Number(getDefaultMaxBeforeChange));


in this scenario we don't need to calculate the difference because whatever we set for the new default value is what it will be (in this case 7) regardless of anything else. So we can just compare directly against that value. ie:

Suggested change

// get added number

const getAdded = Number(checkEDTRMaxTicket) - Number(getDefaultMaxBeforeChange);

// assert maximum ticket allowed at EDTR

expect(Number(checkEDTRMaxTicket)).toBe(getAdded + Number(getDefaultMaxBeforeChange));

// assert maximum ticket allowed at EDTR

expect(Number(checkEDTRMaxTicket)).toBe( 7 );

In the previous tests you were writing for the Events List, we absolutely needed to calculate the number of events dynamically, because the number of events in our tests data array could easily change over time. Hardcoding values there would have resulted in failing tests whenever a new event was added to the test data.

Now that said, it might be worthwhile to verify that the value has actually changed and that the new value is indeed a new value, by incrementing its value, ex:

// Get the default value set on default maximum ticket allowed field const getDefaultMaxBeforeChange = await defaultSettingsManager.getDefaultMaxTicket(); // add 2 to max value newDefaultMax = getDefaultMaxBeforeChange + 2; // Set new value for default maximum ticket allowed await defaultSettingsManager.setNewValueForDefaultMaxTicket( `${newDefaultMax}` );

then you would later assert that the value set in the EDTR is equal to newDefaultMax instead of 7
But it's safe to just use a hardcoded value like 7 since the default value hardcoded in the PHP code is 10

tn3rb · 2022-01-03T17:40:20Z

packages/e2e-tests/specs/admin/events/default-settings/defaultRegistrationStatus.test.ts

@@ -23,24 +23,26 @@ describe('Default registration status test', () => {
 		// Get selected default status and return weither option value or innertext of the option
 		const getSelectedDefaultStatus = await defaultSettingsManager.getSelectedDefaultStatus({ value: true });
 		// assert the current selected registration status
-		expect(getSelectedDefaultStatus).toBe(defaultRegStatusOptions[getSelectedDefaultStatus].value);
+		expect(getSelectedDefaultStatus).toBe(
+			defaultSettingsData.defaultRegStatusOptions[getSelectedDefaultStatus].value


tn3rb · 2022-01-03T18:11:46Z

packages/e2e-tests/utils/admin/events/default-settings/DefaultSettingsManager.ts

+	/**
+	 * Go to add new registration
+	 */
+	goToAddNewReg = async (): Promise<void> => {
+		await Promise.all([page.waitForNavigation(), page.click('a:has-text("Add New Registration")')]);
+	};
+
+	/**
+	 * Check if the value exist in select option innertext
+	 */
+	checkSelectOptionValue = async (value: string): Promise<string> => {
+		return await (await page.$(`.ticket-selector-tbl-qty-slct option:has-text("${value}")`)).innerText();
+	};


I'm thinking these should be moved to a different file:

goToAddNewReg

checkSelectOptionValue

appear to be for the Registrations admin page when filtered for a specific event,
so maybe something like:

packages/e2e-tests/utils/admin/registrations/RegListManager.ts

which would make it easier to find those utilities when working on tests for the Registrations admin and help avoid duplication

tn3rb · 2022-01-03T18:17:56Z

packages/e2e-tests/utils/admin/events/default-settings/DefaultSettingsManager.ts

+	/**
+	 * get "Max Registrations per Transaction" value under "Registration Options"
+	 */
+	getEventRegMaxTicket = async (): Promise<string> => {
+		return await (await page.$('#max-registrants')).getAttribute('value');
+	};


and this should be moved too, maybe something like:

packages/e2e-tests/utils/admin/events/editor/RegistrationOptions.ts

which could contain utilities for all of the inputs in that card:

Default Registration Status

Ticket Selector Enabled

Max Registrations per Transaction

Alternative Registration Page

but you don't have to create functions for those in this PR.

again, this will help anyone (ie: you 😄) writing tests for the EDTR and hopefully help avoid duplication

Oh I see hehehe I will update it, thank you for the comment @tn3rb

tn3rb

yup... perfect now 💯

eeteamcodebase added the S4: in progress 🚧 status label Dec 20, 2021

github-actions bot added C: tests 🧪 category D: Packages 📦 domain: Barista Packages labels Dec 20, 2021

tn3rb changed the title ~~E2 e default maximum tickets~~ E2E default maximum tickets Dec 20, 2021

tn3rb reviewed Dec 20, 2021

View reviewed changes

tn3rb requested changes Dec 20, 2021

View reviewed changes

tn3rb assigned marlonhario Dec 21, 2021

tn3rb added the T: deprecated ⚠️ type: DEP - soon-to-be removed features label Dec 21, 2021

tn3rb requested changes Dec 22, 2021

View reviewed changes

marlonhario added 4 commits December 23, 2021 22:22

E2E test for default maximum tickets allowed at default settings.

ea175c7

Initial fix.

43db8d6

Finalize code for default maximum allowed ticket test.

3604499

Fix request changes.

d8e3efa

marlonhario force-pushed the E2E-default-maximum-tickets branch from 7ddcb74 to d8e3efa Compare December 23, 2021 14:22

Fix request changes for correct flow of test.

ef1b5a3

marlonhario requested a review from tn3rb December 23, 2021 15:51

eeteamcodebase added S7: please fix 💉 status and removed S4: in progress 🚧 status labels Dec 23, 2021

Correcting comment.

eb4e0c6

tn3rb requested changes Jan 3, 2022

View reviewed changes

Fix request changes.

c57282d

tn3rb approved these changes Jan 4, 2022

View reviewed changes

tn3rb merged commit 3edfdf3 into master Jan 4, 2022

tn3rb deleted the E2E-default-maximum-tickets branch January 4, 2022 17:26

eeteamcodebase added S11: completed 🚀 status and removed S7: please fix 💉 status labels Jan 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

E2E default maximum tickets #1108

E2E default maximum tickets #1108

marlonhario commented Dec 20, 2021

tn3rb Dec 20, 2021

tn3rb Dec 20, 2021

marlonhario Dec 22, 2021

tn3rb Dec 20, 2021

marlonhario Dec 22, 2021

tn3rb Dec 20, 2021

tn3rb Dec 20, 2021 •

edited

Loading

tn3rb left a comment

tn3rb left a comment

tn3rb left a comment

tn3rb Jan 3, 2022

tn3rb Jan 3, 2022

tn3rb Jan 3, 2022

tn3rb Jan 3, 2022

marlonhario Jan 4, 2022

tn3rb left a comment

E2E default maximum tickets #1108

E2E default maximum tickets #1108

Conversation

marlonhario commented Dec 20, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tn3rb Dec 20, 2021 • edited Loading

Choose a reason for hiding this comment

tn3rb left a comment

Choose a reason for hiding this comment

tn3rb left a comment

Choose a reason for hiding this comment

tn3rb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tn3rb left a comment

Choose a reason for hiding this comment

tn3rb Dec 20, 2021 •

edited

Loading