Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate E2E deps under its own package #1243

Merged
merged 9 commits into from
Jul 24, 2023
Merged

Consolidate E2E deps under its own package #1243

merged 9 commits into from
Jul 24, 2023

Conversation

alexkuc
Copy link
Contributor

@alexkuc alexkuc commented Jul 24, 2023

Consolidate E2E package including dependencies, config files, etc. The purpose is the following:

  • I require additional e2e only deps to be installed and it's much better to track them under e2e package as opposed to root workspace
  • we discussed that at some point we might move e2e under its own repo, so having files consolidated in the package as opposed to having them scattered all over repo makes it easier
  • I require some specific ts-node adjustments that I'd rather do as a part of e2e package as opposed to updating global tsconfig.json

@alexkuc alexkuc added T: chore 🧹 type: REPO - maintenance P3: med priority 😐 priority: medium C: tests 🧪 category S1: new 👶🏻 status D: REPO 💾 domain: Repository labels Jul 24, 2023
@alexkuc alexkuc self-assigned this Jul 24, 2023
@alexkuc alexkuc marked this pull request as ready for review July 24, 2023 19:18
@alexkuc alexkuc requested a review from tn3rb July 24, 2023 19:18
@github-actions github-actions bot removed D: REPO 💾 domain: Repository C: tests 🧪 category labels Jul 24, 2023
@alexkuc alexkuc mentioned this pull request Jul 21, 2023
Closed
76 tasks
tn3rb
tn3rb previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@tn3rb tn3rb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME JOB

Absolutely fantastic! This should have been done this way from the start.

@alexkuc
Copy link
Contributor Author

alexkuc commented Jul 24, 2023

Will wait for CI checks and if everything is good, I'll merge this

tn3rb
tn3rb approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@tn3rb tn3rb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@alexkuc alexkuc merged commit fb9c2b0 into master Jul 24, 2023
7 checks passed
@alexkuc alexkuc deleted the CHORE/consolidate-e2e-deps branch July 24, 2023 19:41
alexkuc added a commit that referenced this pull request Jul 24, 2023
@alexkuc
Fix E2E global cleanup
b99a386 
Regression introduced as a part of PR #1243
alexkuc added a commit that referenced this pull request Jul 27, 2023
@alexkuc
Fix E2E global cleanup
70bd90a 
Regression introduced as a part of PR #1243
alexkuc added a commit that referenced this pull request Jul 27, 2023
@alexkuc
Fix E2E global cleanup
045fcc3 
Regression introduced as a part of PR #1243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tn3rb tn3rb tn3rb approved these changes

Assignees

@alexkuc alexkuc

Labels
C: assets 💎 category C: build process 🔨 category P3: med priority 😐 priority: medium T: chore 🧹 type: REPO - maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexkuc @tn3rb @garthkoyle @eeteamcodebase