Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests show no output and run abnormally long #1255

Closed
wants to merge 2 commits into from
Closed

E2E tests show no output and run abnormally long #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdcbd42
Add output for git_ref in e2e-checks.yml
alexkuc Aug 23, 2023
ffb55b7
Test
alexkuc Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/e2e-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ jobs:
run: |
if [ ! -z "${HEAD_REF}" ]
then
echo "Found branch name in github.event.pull_request.head.ref"
echo "Found branch name in github.event.pull_request.head.ref: $HEAD_RED"
echo branch="$HEAD_REF" >> $GITHUB_OUTPUT
else
echo "Using gh cli to get branch name"
echo branch=$(gh pr view $PR --repo $REPO --json headRefName --jq '.
headRefName') >> $GITHUB_OUTPUT
branch=$(gh pr view $PR --repo $REPO --json headRefName --jq '.headRefName')
echo "Found branch using gh cli: $branch"
echo branch="$branch" >> $GITHUB_OUTPUT
fi
env:
HEAD_REF: ${{ github.event.pull_request.head.ref }}
Expand Down
17 changes: 9 additions & 8 deletions e2e-tests/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,15 @@ export default defineConfig({
// dependencies: ['setup'],
// },

{
name: 'webkit',
use: {
...devices['Desktop Safari'],
viewport, // see comment next to variable declaration
},
dependencies: ['setup'],
},
// TODO: test, uncomment me
// {
// name: 'webkit',
// use: {
// ...devices['Desktop Safari'],
// viewport, // see comment next to variable declaration
// },
// dependencies: ['setup'],
// },

/* Test against mobile viewports. */
// {
Expand Down
Loading