Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow down type of the property __typename in the interface Entity #1262

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Narrow down type of the property __typename in the interface Entity #1262

merged 2 commits into from
Sep 19, 2023

Conversation

alexkuc
Copy link
Contributor

@alexkuc alexkuc commented Sep 19, 2023

I think we could benefit from a more narrow type for __typename property since we can infer those values from Cafe repository since those values are not dynamically generated but come from concretely defined classes

@alexkuc alexkuc added T: chore 🧹 type: REPO - maintenance D: Packages 📦 domain: Barista Packages P3: med priority 😐 priority: medium S1: new 👶🏻 status labels Sep 19, 2023
@alexkuc alexkuc requested a review from tn3rb September 19, 2023 19:29
@alexkuc alexkuc self-assigned this Sep 19, 2023
@alexkuc
Copy link
Contributor Author

alexkuc commented Sep 19, 2023

Ran all unit tests locally with success:

Test Suites: 236 passed, 236 total
Tests:       1250 passed, 1250 total

@alexkuc alexkuc changed the title Narrow down property of the interface Entity Narrow down type of the property __typename in the interface Entity Sep 19, 2023
@alexkuc alexkuc removed the request for review from tn3rb September 19, 2023 20:09
@alexkuc alexkuc requested a review from tn3rb September 19, 2023 20:09
tn3rb
tn3rb previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@tn3rb tn3rb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to approve, but I did have a couple of super minor comments

packages/data/src/types.ts Show resolved Hide resolved
packages/data/src/types.ts Outdated Show resolved Hide resolved
@alexkuc alexkuc requested a review from tn3rb September 19, 2023 20:47
tn3rb
tn3rb approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@tn3rb tn3rb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 👍🏻

@alexkuc alexkuc merged commit 3a2765a into master Sep 19, 2023
20 checks passed
@alexkuc alexkuc deleted the CHORE/update-entity-interface branch September 19, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tn3rb tn3rb tn3rb approved these changes

Assignees

@garthkoyle garthkoyle

@alexkuc alexkuc

@Pebblo Pebblo

@kingrio13 kingrio13

@Saam01 Saam01

Labels
C: data systems 🗑 category D: Packages 📦 domain: Barista Packages P3: med priority 😐 priority: medium S11: completed 🚀 status T: chore 🧹 type: REPO - maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alexkuc @tn3rb @garthkoyle @eeteamcodebase @Pebblo @kingrio13 @Saam01