Create package "@eventespresso/config" #1302
Conversation
github-actions
bot
added
C: automation & deployment ⚙️
github-actions
bot
removed
C: accessibility ♿
|
Rebased and force-pushed due to merging of #1298 into trunk |
|
Current local commit sha is
|
| // TODO: consolidate data types | ||
| // LATER: consolidate data types |
There was a problem hiding this comment.
There is a separate GH issue now for this and related LATERs - #1301
| @@ -1,5 +1,6 @@ | |||
| module.exports = [ | |||
| /* LEVEL 0 */ ['types'], | |||
| /* LEVEL -1 */ ['types'], | |||
There was a problem hiding this comment.
FYI... those indexes are just for display purposes... you could have just changed them to go from 1 - 10, or 1 - 11, or whatever
There was a problem hiding this comment.
Yeah, I figured that. Didn't want to introduce unnecessary change to PR hence -1.
| decimalPlaces: 2, | ||
| decimalMark: '.', | ||
| thousandsSeparator: ',', | ||
| subunits: 100, // Math.pow(10, 2); |
There was a problem hiding this comment.
Explanation at how we arrive at number 100
There was a problem hiding this comment.
right, based on the decimal places
There was a problem hiding this comment.
My interpretation of the default value came from here:
By default value, I mean when the config and all subsequent properties are undefined.
| @@ -1,5 +1,6 @@ | |||
| module.exports = [ | |||
| /* LEVEL 0 */ ['types'], | |||
| /* LEVEL -1 */ ['types'], | |||
There was a problem hiding this comment.
FYI... those indexes are just for display purposes... you could have just changed them to go from 1 - 10, or 1 - 11, or whatever
| decimalPlaces: 2, | ||
| decimalMark: '.', | ||
| thousandsSeparator: ',', | ||
| subunits: 100, // Math.pow(10, 2); |
There was a problem hiding this comment.
right, based on the decimal places
alexkuc
force-pushed
the
MOD/create-package-config
branch
from
3846093
to
49162e8
Compare
|
Re-tested with commit sha
|
eeteamcodebase
added
S11: completed 🚀
Wait for PR #1298 to be mergedFix #1299