Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tpc price fields v2 #1318

Closed
wants to merge 72 commits into from
Closed

Refactor tpc price fields v2 #1318

wants to merge 72 commits into from

Conversation

alexkuc
Copy link
Contributor

@alexkuc alexkuc commented May 28, 2024

New attempt at #1312 except fixing #1312 (comment)

alexkuc added 30 commits May 3, 2024 22:03
@alexkuc
Always show summary of unit tests
593118a
@alexkuc
Create static method make() on Factory.ts
3307352
@alexkuc
Fix decimal mark for test data
4cd24a7
@alexkuc
Fix typo in data.calculations.test.ts
ddeb29b
@alexkuc
Rename test in parsedAmount.test.ts
5200bdc
@alexkuc
Fix order of expect-result in amountsMatch.test.ts
67dfaf3
@alexkuc
Work-in-progress
e280281
@alexkuc
Work-in-progress
dc09db5
@alexkuc
Work-in-progress
6c468c2
@alexkuc
Example (test file)
c5e09bc
@alexkuc
Add comment
d74e7cf
@alexkuc
Add jsdoc to TicketPriceField.tsx
f11fc0e
@alexkuc
Create base for price-related components
0449cf7
@alexkuc
Add price-field component
fe671c6
@alexkuc
Add money-config component
71ea198
@alexkuc
Add component formatted-price
65fbe34
@alexkuc
Add sub-component for input called "amount"
6a9ed9b
@alexkuc
Add sub-component Description to "amount"
9b1e6aa
@alexkuc
Add sub-component ID to "amount"
8a4c57d
@alexkuc
Add sub-component Name to "amount"
e68d4e7
@alexkuc
Add sub-component Order to "amount"
20f12d0
@alexkuc
Add sub-component Type to "amount"
d72f7fc
@alexkuc
Export components from directory "price"
4bdadd8
@alexkuc
Add missing styles.scss
6600510
@alexkuc
Move component FormattedInput under directory "input"
f5b8489
@alexkuc
Use new components instead of old ones
fe1b867
@alexkuc
Remove old components
f5d71c5
@alexkuc
Remove old inputs
035177b
@alexkuc
Tell ESLint to ignore temporary files
69b8bce
@alexkuc
Move component BaseNumberInputField
e7132d9
@alexkuc
Copy link
Contributor Author

alexkuc commented May 28, 2024

Confirmed locally that #1312 did cause a regression as ran against commit prior to PR #1312:

image

@alexkuc
Copy link
Contributor Author

alexkuc commented May 29, 2024

Closing as going to implement a standalone PR for fixing this bug

@alexkuc alexkuc closed this May 29, 2024
@alexkuc alexkuc deleted the MOD/refactor-tpc-price-fields-v2 branch May 29, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: assets 💎 category C: automation & deployment ⚙️ category C: data systems 🗑 category C: services 🤝 category C: tests 🧪 category C: UI/UX 🚽 category D: Packages 📦 domain: Barista Packages S4: in progress 🚧 status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexkuc @eeteamcodebase