Form Builder: Improve DnD performance #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzoorwanijk
added
C: UI/UX 🚽
tn3rb
reviewed
Jun 11, 2021
Comment on lines
+13
to
+21
| export const FormSections: React.FC<FormSectionsProps> = memo(({ formSections }) => { | ||
| return ( | ||
| <> | ||
| {formSections.map((formSection, index) => ( | ||
| <FormSection key={formSection.UUID} formSection={formSection} index={index} /> | ||
| ))} | ||
| </> | ||
| ); | ||
| }, getPropsAreEqual([['formSections']])); |
tn3rb
approved these changes
Jun 11, 2021
|
let's assume that that one test passed as it only failed due to some asset upload failing, and these changes don't affect TAM at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation of #897 , this PR improves DnD performance for Form Builder sections and elements.
Here is how smooth the DnD is now...
