Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secured connection to kafka for both consumer and producer. Suppo… #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

selimyanat
Copy link

Use a kafka secure connection only if security protocol is different than PLAINTEXT . Add support for secure connection to kafka AdminClient

…rt secure

connection with kafka admin client.
@craigwilliams84
Copy link
Collaborator

Hey, thanks for this. I'm not sure I understand why the if clause has been inverted. Isn't this saying, 'if plaintest security is not configured in properties, then go ahead and enable plaintext security'?

@selimyanat
Copy link
Author

selimyanat commented Oct 9, 2019

Hi,
Basically, the security.protocol can be one of those values PLAINTEXT, SASL_PLAINTEXT, SASL_SSL, SSL. So if the security.protocol property is different than PLAINTEXT security should be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants