Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no space after closing parenthesis in control statements in view files #7

Merged
merged 1 commit into from
Dec 21, 2019
Merged

no space after closing parenthesis in control statements in view files #7

merged 1 commit into from
Dec 21, 2019

Conversation

rieschl
Copy link
Member

@rieschl rieschl commented Dec 21, 2019

e.g. <?php if ($foo): ?>

@rieschl rieschl self-assigned this Dec 21, 2019
@rieschl rieschl merged commit 57cfbc1 into master Dec 21, 2019
@rieschl rieschl deleted the no-space-control-view branch December 21, 2019 15:13
@MidnightDesign
Copy link
Contributor

A test case would have been nice. I have no idea what this rule does/changes.

@rieschl
Copy link
Member Author

rieschl commented Dec 23, 2019

https://github.com/squizlabs/PHP_CodeSniffer/wiki/Customisable-Sniff-Properties#squizcontrolstructurescontrolsignature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MidnightDesign MidnightDesign Awaiting requested review from MidnightDesign

@wolfgangschaefer wolfgangschaefer Awaiting requested review from wolfgangschaefer

Assignees

@rieschl rieschl

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rieschl @MidnightDesign