Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipv6 patch breaks dnspython reverse.from_address function #203

Closed
ekarlso opened this issue Feb 23, 2015 · 8 comments
Closed

ipv6 patch breaks dnspython reverse.from_address function #203

ekarlso opened this issue Feb 23, 2015 · 8 comments

Comments

@ekarlso
Copy link

ekarlso commented Feb 23, 2015

I suspect a6ce444 is the culprit.

I have verified that before the commit it works fine before the commit.

Example:

import eventlet
from dns import reversename

eventlet.monkey_patch(all=True)

reversename.from_address("10.0.0.1")


Exception:
Traceback (most recent call last):
  File "test.py", line 6, in <module>
    reversename.from_address("10.0.0.1")
  File "/home/karlsone/projects/dnsaas/designate/.venv/local/lib/python2.7/site-packages/dns/reversename.py", line 46, in from_address
    return dns.name.from_text('.'.join(parts), origin=origin)
  File "/home/karlsone/projects/dnsaas/designate/.venv/local/lib/python2.7/site-packages/dns/name.py", line 607, in from_text
    raise ValueError("origin must be a Name or None")
ValueError: origin must be a Name or None
@kiall
Copy link

kiall commented Feb 23, 2015

Downstream bug against OpenStack Designate - https://bugs.launchpad.net/designate/+bug/1424621

@ekarlso
Copy link
Author

ekarlso commented Feb 23, 2015

@ekarlso ekarlso closed this as completed Feb 23, 2015
@temoto
Copy link
Member

temoto commented Feb 23, 2015

Thank you, bugfix release is coming soon.

@temoto temoto reopened this Feb 23, 2015
@kiall
Copy link

kiall commented Feb 24, 2015

Hey @temoto - Any luck finding the root cause? I've dug about as far into it as I can given my lack of experience with eventlet's codebase, and came up empty ;)

@temoto
Copy link
Member

temoto commented Feb 24, 2015

@kiall not yet, debugging

@temoto
Copy link
Member

temoto commented Feb 24, 2015

The problem is in patching dns.name.Name. Fix will be released today.

temoto added a commit that referenced this issue Feb 24, 2015
#203

Also, separate tox environments py{27,34,py}-dns that install and test green DNS.
temoto added a commit that referenced this issue Feb 24, 2015
#203

Also, separate tox environments py{27,34,py}-dns that install and test green DNS.
temoto added a commit that referenced this issue Feb 24, 2015
#203

Also, separate tox environments py{27,34,py}-dns that install and test green DNS.
@temoto
Copy link
Member

temoto commented Feb 25, 2015

v0.17.1 with this bug fixed is out on PyPi. Thanks for reporting.

@temoto temoto closed this as completed Feb 25, 2015
@kiall
Copy link

kiall commented Feb 25, 2015

Thanks :) Sadly, the fixed version has highlighted other issues in our code / tests .. Whoops! Either way, the original issue does seem to be fixed and I suspect the remaining issues are all ours to fix.. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants