Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating Python 2.7, 3.4 and 3.5 support #623

Closed
jstasiak opened this issue Jul 1, 2020 · 8 comments · Fixed by #665
Closed

Deprecating Python 2.7, 3.4 and 3.5 support #623

jstasiak opened this issue Jul 1, 2020 · 8 comments · Fixed by #665

Comments

@jstasiak
Copy link
Contributor

jstasiak commented Jul 1, 2020

3.4 is way after its EOL, 2.7's corpse is suspiciously lively but I wouldn't want to deal with it and 3.5 is EOL soon, I'd like to deprecate the support for them in the next release (0.25.x?) and drop it in the next larger one (0.26.0). Any input? @temoto we talked about it few years back, what's your opinion on this now?

@jstasiak
Copy link
Contributor Author

jstasiak commented Jul 1, 2020

According to https://pypistats.org/packages/eventlet Eventlet installs are ~11% coming from Python 2.7, ~5% Python 3.5 and Python 3.4 numbers are negligible (~0.2%).

@temoto
Copy link
Member

temoto commented Jul 5, 2020

Hi, Jakub.

Drop 2.7

I don't like idea of abandoning 11% installs. But yes, it's the right move. I'm going to do same with httplib2.

For all folks who are negatively affected by this decision: truly sorry, I could still backport some bugfixes onto 2.7 compatible version but really not for long.

Drop 3.4

Seems perfectly reasonable to me. Especially since 3.5 introduced interrupted syscall retries which is very relevant to eventlet.

Drop 3.5

On quick glance I didn't see any benefits to dropping 3.5. Please say.

temoto added a commit that referenced this issue Jul 6, 2020
@jstasiak
Copy link
Contributor Author

jstasiak commented Jul 7, 2020

Fair enough on Python 3.5, I had in mind some differences but turns out they're not really relevant here so I retract that point. I'd still like to drop 2.7 as the contributor resources are already spread thin and I don't like the idea of trying to satisfy Python 2.7 the next time I write or merge a patch, not in my free time (if someone paid me to do it it'd be a different story).

@temoto
Copy link
Member

temoto commented Jul 7, 2020

By "backport some bugfixes onto 2.7 compatible version" I meant PyPI release, not live branch.

@jstasiak
Copy link
Contributor Author

So I forgot about this subject. Are we fine with deprecating 2.7 and 3.4? I can cut a PR with an updated docs to say this (+ maybe a runtime warning on import).

@hugovk
Copy link
Contributor

hugovk commented Oct 20, 2020

Drop 3.5

On quick glance I didn't see any benefits to dropping 3.5. Please say.

f-strings! It's also now EOL.

@jstasiak
Copy link
Contributor Author

Not a significant reason for us, but I'll take it anyway ;)

@temoto
Copy link
Member

temoto commented Oct 21, 2020

So I forgot about this subject. Are we fine with deprecating 2.7 and 3.4? I can cut a PR with an updated docs to say this (+ maybe a runtime warning on import).

Deprecating - definitely yes. With big letter announcement in readme and website. BTW, that pypistats show that py2 downloads are steadily decreasing, that's comforting.

jstasiak added a commit that referenced this issue Nov 4, 2020
This will allow us to remove some code and better spend the available
resources. Both 2.7 and 3.4 are EOL.

Closes GH-623.
jstasiak added a commit that referenced this issue Nov 4, 2020
This will allow us to remove some code and better spend the available
resources. Both 2.7 and 3.4 are EOL.

Closes GH-623.
@temoto temoto unpinned this issue Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants