Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure/fix codecov so it's not spuriously red #833

Open
itamarst opened this issue Dec 14, 2023 · 4 comments
Open

Reconfigure/fix codecov so it's not spuriously red #833

itamarst opened this issue Dec 14, 2023 · 4 comments
Labels

Comments

@itamarst
Copy link
Contributor

itamarst commented Dec 14, 2023

Whatever codecov/patch CI job is doing now, CI often ends up marked red despite everything passing and coverage not decreasing.

@itamarst itamarst assigned itamarst and unassigned itamarst Dec 14, 2023
@itamarst
Copy link
Contributor Author

One problem is that monkeypatching code is not run in the test process, it's tested via subprocesses. So possibly making sure subprocesses in tests get coverage too will fix most of it.

@itamarst itamarst changed the title Green CI, part 3: Reconfigure/fix codecov so it's not constantly red Green CI, part 3: Reconfigure/fix codecov so it's not spuriously red Dec 14, 2023
@itamarst
Copy link
Contributor Author

Given the above, this is probably not as high a priority.

@itamarst itamarst changed the title Green CI, part 3: Reconfigure/fix codecov so it's not spuriously red Reconfigure/fix codecov so it's not spuriously red Dec 14, 2023
@itamarst
Copy link
Contributor Author

#836 might fix the subprocess issue, it's possible pytest-cov makes this work automatically.

@4383 4383 added the tests label Dec 15, 2023
@4383
Copy link
Member

4383 commented Dec 15, 2023

Given the above, this is probably not as high a priority.

Yeah not a priority...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants