Replace nose with pytest

[itamarst]

Fixes #638

Unless nose3 starts being maintained again, this is a prerequisite for Python 3.12 support. nose3 is, in any case, essentially a dead project.

• Everything passes in CI
• Everything runs in CI. nose runs 722 tests, pytest now runs 722 tests too.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97dc606) 32% compared to head (2d4c3cf) 53%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #836     +/-   ##
=======================================
+ Coverage      32%    53%    +21%     
=======================================
  Files          88     88             
  Lines       14979   9848   -5131     
  Branches     1515   1841    +326     
=======================================
+ Hits         4857   5299    +442     
+ Misses       9773   4164   -5609     
- Partials      349    385     +36     

Flag	Coverage Δ
ipv6	22% <ø> (+10%)	⬆️
py310epolls	52% <ø> (+16%)	⬆️
py310poll	52% <ø> (+16%)	⬆️
py310selects	52% <ø> (+16%)	⬆️
py311epolls	52% <ø> (+21%)	⬆️
py38epolls	52% <ø> (+10%)	⬆️
py38openssl	50% <ø> (+10%)	⬆️
py38poll	52% <ø> (+10%)	⬆️
py38selects	51% <ø> (+10%)	⬆️
py39dnspython1	50% <ø> (+10%)	⬆️
py39epolls	52% <ø> (+10%)	⬆️
py39poll	52% <ø> (+10%)	⬆️
py39selects	51% <ø> (+10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[4383]

I'm ok to move from nose to pytest, motivations (#638) looks legit.

[itamarst]

This is fun. nose when running tests does 722 tests, when you run nosetests --collect-only it finds 723 😭

[itamarst]

This was for setup.py test, which is now deprecated.

[4383]

yes, no problem

[4383]

This is fun. nose when running tests does 722 tests, when you run nosetests --collect-only it finds 723

I'm just guessing... Maybe 'SkipTest' is just skipped at runtime or something like that, and so, and therefore counted only in other cases (collect), although it seems unlikely that we'll skip only a single test...

[4383]

God job! Thanks @itamarst