-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_server_info to db_pool.py #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Is this patch still relevant?
AFAICS these changes make sense.
Wow, that was a long time ago! :-D I guess step one is to rebase this! Feel free to do that and push and so on if you have time... I might have time to look at it in the weekend otherwise. |
hm... something went wrong during your rebase. All tests are failing and your addition does not seems in the right place in the code like before. Please check |
Django uses this for example.
I guess it should be like this now.. ? |
Looks better, thanks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
=====================================
Coverage 55% 55%
=====================================
Files 90 90
Lines 9878 9959 +81
Branches 1831 1855 +24
=====================================
+ Hits 5460 5537 +77
- Misses 4044 4047 +3
- Partials 374 375 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Django uses this for example.