[green.zmq] Fix args/kwargs of socket's methods #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make socket's methods consistent with official pyzmq library and its documentation.
gdavoian
changed the title
|
Thanks, gdavoian! My bad with arguments ... |
|
this should fix #376 |
temoto
pushed a commit
that referenced
this pull request
Jan 13, 2017
temoto
pushed a commit
that referenced
this pull request
Jan 13, 2017
|
I am ok, feel free to fix the patch. I don't mind, of course. |
Current coverage is 53.44% (diff: 84.09%)@@ master #344 diff @@
==========================================
Files 78 78
Lines 8902 8948 +46
Methods 0 0
Messages 0 0
Branches 1532 1538 +6
==========================================
+ Hits 4742 4782 +40
- Misses 3842 3848 +6
Partials 318 318
|
|
Merged in master ceff431 will be published in next release v0.21 Have a nice day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make socket's methods consistent with official pyzmq library and its documentation.