_recv_loop behaviour with recv_into on closed sock #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure `_recv_loop` returns the correct value when `recv_meth` is of foo_into type (fills a buffer and returns number of bytes, not the data)
davidszotten
force-pushed
the
_recv_loop_socket_closed
branch
from
34cc1f7
to
5db47d6
Compare
mattbennett
added a commit
to mattbennett/nameko
that referenced
this pull request
Oct 27, 2016
|
failing test looks unrelated but i'm not allowed to re-trigger the build :( |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure
_recv_loopreturns the correct value whenrecv_methis offoo_into type (fills a buffer and returns number of bytes, not the data)