Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests.greendns_test.TestGetaddrinfo #375

Merged
merged 1 commit into from Jan 13, 2017
Merged

Conversation

Kobla
Copy link

@Kobla Kobla commented Jan 12, 2017

Asserting udp for ssh introduce test failures under debian unstable
because netbase 5.4 removed ssh (22/udp).
This fix changes ssh -> domain, which better suit for test name and
allows tcp and udp simultaneously.

Asserting udp for ssh introduce test failures under debian unstable
because netbase 5.4 removed ssh (22/udp).
This fix changes ssh -> domain, which better suit for test name and
allows tcp and udp simultaneously.
@onovy
Copy link
Contributor

onovy commented Jan 12, 2017

CI fails is not related to this change, see #374

@codecov-io
Copy link

codecov-io commented Jan 12, 2017

Current coverage is 53% (diff: 100%)

Merging #375 into master will decrease coverage by <1%

@@             master       #375   diff @@
==========================================
  Files            78         78          
  Lines          8948       8948          
  Methods           0          0          
  Messages          0          0          
  Branches       1538       1538          
==========================================
- Hits           4783       4779     -4   
- Misses         3852       3854     +2   
- Partials        313        315     +2   

Powered by Codecov. Last update 54be759...b20d2f2

@temoto
Copy link
Member

temoto commented Jan 13, 2017

Just out of curiosity, are you saying new netbase package leaves Debian with /etc/protocols without ssh-22 line?

@temoto temoto merged commit b20d2f2 into eventlet:master Jan 13, 2017
@temoto
Copy link
Member

temoto commented Jan 13, 2017

Thanks a lot.

@Kobla
Copy link
Author

Kobla commented Jan 13, 2017

I dont know whether the /etc/protocols will contain ssh-22 line.
I think ssh 22/udp will be removed from /etc/services. (ssh 22/tcp persists)

@temoto
Copy link
Member

temoto commented Jan 13, 2017

Yeah, I meant services. Ah, now I get it. It's tcp/udp difference. That's clearly mistake on Eventlet side, thanks for fixing.

@temoto temoto added this to the v0.21 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants