Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be explicit about expecting bytes from sock.recv #391

Merged
merged 1 commit into from Apr 12, 2017

Conversation

mattbennett
Copy link
Contributor

On Python3, callingeventlet.support.greendns._net_read will raise "TypeError: Can't convert 'bytes' object to str implicitly".

This happens when resolution is requested over TCP, or if resolution falls back to TCP when the UDP response is truncated (which is how we found it).

The bug was fixed in dnspython here.

@temoto
Copy link
Member

temoto commented Feb 17, 2017

Thanks, I want to have a test case on this.
If there's no test in reasonable time, LGTM from me, I'll merge or @jstasiak also has access.

@codecov-io
Copy link

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff          @@
##           master   #391   +/-   ##
=====================================
  Coverage      54%    54%           
=====================================
  Files          79     79           
  Lines        9036   9036           
  Branches     1559   1559           
=====================================
  Hits         4889   4889           
  Misses       3826   3826           
  Partials      321    321
Impacted Files Coverage Δ
eventlet/support/greendns.py 61% <ø> (ø)
eventlet/hubs/hub.py 89% <ø> (-1%)
eventlet/event.py 81% <ø> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f2ef8...eb611c8. Read the comment docs.

@gugu
Copy link

gugu commented Apr 11, 2017

@temoto can you please merge it? There is no response from anyone, and greendns is buggy in python 3

@temoto temoto merged commit 76df4d3 into eventlet:master Apr 12, 2017
@temoto
Copy link
Member

temoto commented Apr 12, 2017

Привет, Андрей. 👍

Fix is merged in master fa87d41

@gugu
Copy link

gugu commented Apr 12, 2017

Спасибо!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants