New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate test crt #516
Regenerate test crt #516
Conversation
Newer OpenSSL requires RSA key at least 2048 bits
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
=====================================
Coverage 46% 46%
=====================================
Files 81 81
Lines 7948 7948
Branches 1361 1361
=====================================
Hits 3665 3665
Misses 4031 4031
Partials 252 252
Continue to review full report at Codecov.
|
@beltran, comments? |
+1, out of curiosity, how was they key generated @onovy ? |
@onovy do you want to make patch that will generate key/cert instead? |
hi, this is command:
Because validity of certificate is not checked I don't see any benefit in autogenerating certificate during test. Generating RSA2048 key is time consuming and needs lot of random numbers. When OpenSSL changes minimum size and/or cipher setup, you need to change that command / regenerate certificate again. |
Right, CPU intensive, I didn't think of that. |
@onovy thank you. |
Newer OpenSSL requires RSA key at least 2048 bits