Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate test crt #516

Merged
merged 1 commit into from Aug 24, 2018
Merged

Regenerate test crt #516

merged 1 commit into from Aug 24, 2018

Conversation

onovy
Copy link
Contributor

@onovy onovy commented Aug 22, 2018

Newer OpenSSL requires RSA key at least 2048 bits

Newer OpenSSL requires RSA key at least 2048 bits
@codecov-io
Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #516 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #516   +/-   ##
=====================================
  Coverage      46%    46%           
=====================================
  Files          81     81           
  Lines        7948   7948           
  Branches     1361   1361           
=====================================
  Hits         3665   3665           
  Misses       4031   4031           
  Partials      252    252
Flag Coverage Δ
#ipv6 14% <ø> (ø) ⬆️
#py27epolls 49% <ø> (ø) ⬆️
#py27poll 49% <ø> (ø) ⬆️
#py27selects 48% <ø> (ø) ⬆️
#py34epolls 42% <ø> (ø) ⬆️
#py34poll 42% <ø> (-1%) ⬇️
#py34selects 41% <ø> (-1%) ⬇️
#py35epolls 42% <ø> (ø) ⬆️
#py35poll 41% <ø> (-1%) ⬇️
#py35selects 41% <ø> (-1%) ⬇️
#py36epolls 42% <ø> (-1%) ⬇️
#py36poll 41% <ø> (ø) ⬆️
#py36selects 41% <ø> (?)
#py37epolls 42% <ø> (?)
#py37poll 42% <ø> (ø) ⬆️
#py37selects 41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90fc7af...96fccf3. Read the comment docs.

@nat-goodspeed
Copy link
Contributor

@beltran, comments?

@beltran
Copy link
Contributor

beltran commented Aug 22, 2018

+1, out of curiosity, how was they key generated @onovy ?

@temoto
Copy link
Member

temoto commented Aug 22, 2018

@onovy do you want to make patch that will generate key/cert instead?

@onovy
Copy link
Contributor Author

onovy commented Aug 23, 2018

hi,

this is command:

openssl req -x509 -sha256 -nodes -days 3650 -newkey rsa:2048 -keyout test_server.key -out test_server.crt

Because validity of certificate is not checked I don't see any benefit in autogenerating certificate during test. Generating RSA2048 key is time consuming and needs lot of random numbers. When OpenSSL changes minimum size and/or cipher setup, you need to change that command / regenerate certificate again.

@temoto
Copy link
Member

temoto commented Aug 23, 2018

Right, CPU intensive, I didn't think of that.

@temoto temoto merged commit 96fccf3 into eventlet:master Aug 24, 2018
@temoto
Copy link
Member

temoto commented Aug 24, 2018

@onovy thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants