Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using deprecated cgi.parse_qs() to support Python 3.8 #581

Merged
merged 1 commit into from Jul 10, 2019
Merged

Stop using deprecated cgi.parse_qs() to support Python 3.8 #581

merged 1 commit into from Jul 10, 2019

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jul 10, 2019

Fixes #580

@hroncok hroncok mentioned this pull request Jul 10, 2019
Closed
jstasiak
jstasiak approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@jstasiak jstasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jstasiak jstasiak merged commit 7f8d478 into eventlet:master Jul 10, 2019
@jstasiak
Copy link
Contributor

Cheers! For what it's worth it's not necessary to create an issue if you have a pull request ready.

@hroncok
Copy link
Contributor Author

hroncok commented Jul 10, 2019

For what it's worth it's not necessary to create an issue if you have a pull request ready.

Ack. I filed the issue and only after that I started to work on a fix.

@hroncok hroncok deleted the py38 branch July 10, 2019 14:07
@eudoxos eudoxos mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstasiak jstasiak jstasiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cqi.parse_qs was removed in Python 3.8
2 participants
@hroncok @jstasiak