Fix greendns for dnspython 2.3.0+ #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnspython added more type annotations in 2.3.0 -- because of how we reimport the package piece by piece, though, not all of the types would be available during reimport, leading to AttributeErrors like module 'dns.rdtypes' has no attribute 'ANY' Now, do all of our rdtypes special-handling *first*, before reimporting any other submodules. Addresses eventlet#781
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 18, 2023
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit for dnspython as long as we also limit eventlet to >=0.33.3.
potiuk
added a commit
to apache/airflow
that referenced
this pull request
Jan 18, 2023
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit for dnspython as long as we also limit eventlet to >=0.33.3.
ephraimbuddy
pushed a commit
to apache/airflow
that referenced
this pull request
Jan 18, 2023
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit for dnspython as long as we also limit eventlet to >=0.33.3. (cherry picked from commit eaf5675)
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 31, 2023
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit for dnspython as long as we also limit eventlet to >=0.33.3. GitOrigin-RevId: eaf567545b3339c20d2e072fca1d9cdb08c0dec7
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Apr 4, 2023
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit for dnspython as long as we also limit eventlet to >=0.33.3. (cherry picked from commit eaf567545b3339c20d2e072fca1d9cdb08c0dec7) GitOrigin-RevId: a0b464f828b97a6894426ec791714d7fbb6503ba
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2023
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit for dnspython as long as we also limit eventlet to >=0.33.3. GitOrigin-RevId: eaf567545b3339c20d2e072fca1d9cdb08c0dec7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dnspythonadded more type annotations in 2.3.0 -- because of how we reimport the package piece by piece, though, not all of the types would be available during reimport, leading toAttributeErrorslikeNow, do all of our
rdtypesspecial-handling first, before reimporting any other submodules.Addresses #781