[WIP][Greendns] Replace deprecated resolver.query by resolver.resolve

[4383]

Usages of resolver.query are deprecated[1][2][3] and should be replaced by resolver.resolve.

Fix #818

[1] https://dnspython.readthedocs.io/en/latest/whatsnew.html#id8
[2] https://github.com/rthalley/dnspython/blob/adfc942725bd36d28ec53f7e5480ace9eb543bd8/dns/resolver.py#L1360
[3] https://github.com/rthalley/dnspython/blob/adfc942725bd36d28ec53f7e5480ace9eb543bd8/dns/resolver.py#L1596

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d78f8f6) 53% compared to head (7243eeb) 23%.
Report is 2 commits behind head on master.

Files	Patch %	Lines
eventlet/support/greendns.py	0%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #840     +/-   ##
=======================================
- Coverage      53%    23%    -31%     
=======================================
  Files          88     88             
  Lines        9848   9983    +135     
  Branches     1841   1811     -30     
=======================================
- Hits         5299   2317   -2982     
- Misses       4164   7480   +3316     
+ Partials      385    186    -199     

Flag	Coverage Δ
ipv6	23% <0%> (+<1%)	⬆️
py310epolls	?
py310poll	?
py310selects	?
py311epolls	?
py38epolls	?
py38openssl	?
py38poll	?
py38selects	?
py39dnspython1	?
py39epolls	?
py39poll	?
py39selects	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[4383]

This topic seems a bit more complicated than just replacing a deprecated method by a new one.
I followed the suggestions made in #818, but, local tests and CI jobs started to fail with assignation errors like this one:

FAILED tests/greendns_test.py::TestUdp::test_udp_ipv6 - OSError: [Errno 99] Cannot assign requested address

I need further investigation to see what happens.

The latest build is successful because I submitted a new patch set with an empty commit, just to compare...

@blink1073: Please can you give us more details on the way you made your tests and how you triggered this warning?

[4383]

Moving to the new function lead eventlet to:

>               raise NoNameservers(request=self.request, errors=self.errors)                                          
E               dns.resolver.NoNameservers: All nameservers failed to answer the query machine. IN A: 

[blink1073]

Here's the full traceback from pymongo:

/opt/python/3.10/lib/python3.10/contextlib.py:135: in __enter__
 [2023/12/15 07:56:56.991]     return next(self.gen)
 [2023/12/15 07:56:56.991] pymongo/pool.py:1656: in checkout
 [2023/12/15 07:56:56.991]     conn = self._get_conn(handler=handler)
 [2023/12/15 07:56:56.991] pymongo/pool.py:1775: in _get_conn
 [2023/12/15 07:56:56.991]     conn = self.connect(handler=handler)
 [2023/12/15 07:56:56.991] pymongo/pool.py:1605: in connect
 [2023/12/15 07:56:56.991]     sock = _configured_socket(self.address, self.opts)
 [2023/12/15 07:56:56.991] pymongo/pool.py:1291: in _configured_socket
 [2023/12/15 07:56:56.991]     sock = _create_connection(address, options)
 [2023/12/15 07:56:56.991] pymongo/pool.py:1244: in _create_connection
 [2023/12/15 07:56:56.991]     for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
 [2023/12/15 07:56:56.991] .tox/test-eg/lib/python3.10/site-packages/eventlet/support/greendns.py:549: in getaddrinfo
 [2023/12/15 07:56:56.991]     qname, addrs = _getaddrinfo_lookup(host, family, flags)
 [2023/12/15 07:56:56.991] .tox/test-eg/lib/python3.10/site-packages/eventlet/support/greendns.py:511: in _getaddrinfo_lookup
 [2023/12/15 07:56:56.991]     answer = resolve(host, qfamily, False, use_network=use_network)
 [2023/12/15 07:56:56.991] .tox/test-eg/lib/python3.10/site-packages/eventlet/support/greendns.py:456: in resolve
 [2023/12/15 07:56:56.991]     return _proxy.query(name, rdtype, raise_on_no_answer=raises,
 [2023/12/15 07:56:56.991] .tox/test-eg/lib/python3.10/site-packages/eventlet/support/greendns.py:412: in query
 [2023/12/15 07:56:56.991]     return end()
 [2023/12/15 07:56:56.991] .tox/test-eg/lib/python3.10/site-packages/eventlet/support/greendns.py:391: in end
 [2023/12/15 07:56:56.991]     raise result[1]
 [2023/12/15 07:56:56.991] .tox/test-eg/lib/python3.10/site-packages/eventlet/support/greendns.py:372: in step
 [2023/12/15 07:56:56.991]     a = fun(*args, **kwargs)
 [2023/12/15 07:56:56.991] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
 [2023/12/15 07:56:56.991]     def query(
 [2023/12/15 07:56:56.991]         self,
 [2023/12/15 07:56:56.991]         qname: Union[dns.name.Name, str],
 [2023/12/15 07:56:56.991]         rdtype: Union[dns.rdatatype.RdataType, str] = dns.rdatatype.A,
 [2023/12/15 07:56:56.991]         rdclass: Union[dns.rdataclass.RdataClass, str] = dns.rdataclass.IN,
 [2023/12/15 07:56:56.991]         tcp: bool = False,
 [2023/12/15 07:56:56.991]         source: Optional[str] = None,
 [2023/12/15 07:56:56.991]         raise_on_no_answer: bool = True,
 [2023/12/15 07:56:56.991]         source_port: int = 0,
 [2023/12/15 07:56:56.991]         lifetime: Optional[float] = None,
 [2023/12/15 07:56:56.991]     ) -> Answer:  # pragma: no cover
 [2023/12/15 07:56:56.991]         """Query nameservers to find the answer to the question.
 [2023/12/15 07:56:56.991]         This method calls resolve() with ``search=True``, and is
 [2023/12/15 07:56:56.991]         provided for backwards compatibility with prior versions of
 [2023/12/15 07:56:56.991]         dnspython.  See the documentation for the resolve() method for
 [2023/12/15 07:56:56.991]         further details.
 [2023/12/15 07:56:56.991]         """
 [2023/12/15 07:56:56.991] >       warnings.warn(
 [2023/12/15 07:56:56.991]             "please use dns.resolver.Resolver.resolve() instead",
 [2023/12/15 07:56:56.991]             DeprecationWarning,
 [2023/12/15 07:56:56.991]             stacklevel=2,
 [2023/12/15 07:56:56.991]         )
 [2023/12/15 07:56:56.991] E       DeprecationWarning: please use dns.resolver.Resolver.resolve() instead

Our code that uses dnspython directly is here.

We test eventlet integration by applying this patch and then invoking pytest.main on our full test suite.

[4383]

Thanks for the details. Unit tests should be fixed too, I need to rework my patch.

[4383]

resolve and query doesn't have the same signature, and internally query call resolve with search=True, while this option is set to None by default.