Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: PostgreSQLJournal leaking connections #90

Closed
yrashk opened this issue Jul 1, 2016 · 1 comment · Fixed by #91
Closed

Problem: PostgreSQLJournal leaking connections #90

yrashk opened this issue Jul 1, 2016 · 1 comment · Fixed by #91
Labels
bug

Comments

@yrashk
Copy link
Contributor

yrashk commented Jul 1, 2016

This is most likely happening due to npgall/cqengine#74 — that said, we do have a workaround for this — if the iterator was actually finished, it should close.
@yrashk yrashk added the bug label Jul 1, 2016
@yrashk
Copy link
Contributor Author

yrashk commented Jul 1, 2016

The problem is here: https://github.com/eventsourcing/es4j/blob/master/eventsourcing-postgresql/src/main/java/com/eventsourcing/postgresql/PostgreSQLJournal.java#L265

yrashk added a commit to yrashk/es4j that referenced this issue Jul 1, 2016
@yrashk
Problem: repository doesn't store the layout metainformation
3468201 
Solution: make repository generate EntityLayoutIntroduced on demand

This change is fairly massive for a number of reasons. Besides adding generation
of EntityLayoutIntroduced (RFC 8/EMT), the changes are:

1. Repository implementation has been split into eventsourcing-repository module
   to allow it to have a non-circular dependency on eventsourcing-migrations
2. RepositoryImpl has been renamed to StandardRepository for consistency and
   `Repository.create()` has been replaced with `new StandardRepository()`
3. Fixed PostgreSQL connection leaks, closes eventsourcing#90
4. Fixed PostgreSQL Optional serialization and deserialization
5. Fixed composite type treatment with lists inside
@yrashk yrashk mentioned this issue Jul 1, 2016
Merged
yrashk added a commit to yrashk/es4j that referenced this issue Jul 1, 2016
@yrashk
Problem: repository doesn't store the layout metainformation
cef7de7 
Solution: make repository generate EntityLayoutIntroduced on demand

This change is fairly massive for a number of reasons. Besides adding generation
of EntityLayoutIntroduced (RFC 8/EMT), the changes are:

1. Repository implementation has been split into eventsourcing-repository module
   to allow it to have a non-circular dependency on eventsourcing-migrations
2. RepositoryImpl has been renamed to StandardRepository for consistency and
   `Repository.create()` has been replaced with `new StandardRepository()`
3. Fixed PostgreSQL connection leaks, closes eventsourcing#90
4. Fixed PostgreSQL Optional serialization and deserialization
5. Fixed composite type treatment with lists inside
yrashk added a commit to yrashk/es4j that referenced this issue Jul 2, 2016
@yrashk
Problem: repository doesn't store the layout metainformation
ce516d3 
Solution: make repository generate EntityLayoutIntroduced on demand

This change is fairly massive for a number of reasons. Besides adding generation
of EntityLayoutIntroduced (RFC 8/EMT), the changes are:

1. Repository implementation has been split into eventsourcing-repository module
   to allow it to have a non-circular dependency on eventsourcing-migrations
2. RepositoryImpl has been renamed to StandardRepository for consistency and
   `Repository.create()` has been replaced with `new StandardRepository()`
3. Fixed PostgreSQL connection leaks, closes eventsourcing#90
4. Fixed PostgreSQL Optional serialization and deserialization
5. Fixed composite type treatment with lists inside
yrashk added a commit to yrashk/es4j that referenced this issue Jul 2, 2016
@yrashk
Problem: repository doesn't store the layout metainformation
fd98cda 
Solution: make repository generate EntityLayoutIntroduced on demand

This change is fairly massive for a number of reasons. Besides adding generation
of EntityLayoutIntroduced (RFC 8/EMT), the changes are:

1. Repository implementation has been split into eventsourcing-repository module
   to allow it to have a non-circular dependency on eventsourcing-migrations
2. RepositoryImpl has been renamed to StandardRepository for consistency and
   `Repository.create()` has been replaced with `new StandardRepository()`
3. Fixed PostgreSQL connection leaks, closes eventsourcing#90
4. Fixed PostgreSQL Optional serialization and deserialization
5. Fixed composite type treatment with lists inside
@yrashk yrashk closed this as completed in #91 Jul 3, 2016
yrashk added a commit to yrashk/es4j that referenced this issue Sep 14, 2016
@yrashk
Problem: repository doesn't store the layout metainformation
3c7a957 
Solution: make repository generate EntityLayoutIntroduced on demand

This change is fairly massive for a number of reasons. Besides adding generation
of EntityLayoutIntroduced (RFC 8/EMT), the changes are:

1. Repository implementation has been split into eventsourcing-repository module
   to allow it to have a non-circular dependency on eventsourcing-migrations
2. RepositoryImpl has been renamed to StandardRepository for consistency and
   `Repository.create()` has been replaced with `new StandardRepository()`
3. Fixed PostgreSQL connection leaks, closes eventsourcing#90
4. Fixed PostgreSQL Optional serialization and deserialization
5. Fixed composite type treatment with lists inside
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: repository doesn't store the layout metainformation yrashk/es4j
1 participant
@yrashk