Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sagas work with devTools #30

Open
cer opened this issue May 7, 2020 · 3 comments
Open

Make sagas work with devTools #30

cer opened this issue May 7, 2020 · 3 comments

Comments

@cer
Copy link
Collaborator

cer commented May 7, 2020

Problem:

  • devtools uses it's own classloader
  • eventuate libraries use a different classloader
  • DevTools can cause errors such as java.lang.ClassCastException: class X cannot be cast to class X - X and X are from different class loaders

This is the likely solution: spring-projects/spring-boot#3805

Eventuate libraries (including JSonMapper) need to use ThreadLocal.getThread().getContextClassLoader()

@cer
Copy link
Collaborator Author

cer commented Jun 1, 2020

AFAIK as I know that's all that's required.
I'd first try to reproduce the problem by including Devtools and then verify that the change fixes the problem.

@dartartem
Copy link
Contributor

Got it, thank you

dartartem added a commit to dartartem/eventuate-common-1 that referenced this issue Jun 2, 2020
dartartem added a commit to dartartem/eventuate-local that referenced this issue Jun 2, 2020
dartartem added a commit to dartartem/eventuate-tram-core that referenced this issue Jun 2, 2020
dartartem added a commit to dartartem/eventuate-tram-sagas that referenced this issue Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants