unixsocket should be passed along to config in order to configure sockets properly #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sockets properly
|
I suppose a proper spec test to cover this case would have been a nice gesture. Will work on getting that done as well :) EDIT: Looks like you got that covered here: https://github.com/evenup/evenup-redis/blob/master/spec/classes/redis_config_spec.rb#L52-L97 And also, thank you for this module, was the best written one out of the top ones on puppet forge, great work. |
jlambert121
added a commit
that referenced
this pull request
Nov 30, 2013
unixsocket should be passed along to config in order to configure sockets properly
|
Nice catch on this - sorry about the bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title states, this fix is necessary to have the unixsocket parameter work.
Currently it will always pass config.pp an empty string which in turn never gets the unixsocket directive into the redis configuration.