Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 5 | Team, Task, Settings pages #734

Closed
80 tasks done
KostyaEver opened this issue Mar 30, 2023 · 16 comments
Closed
80 tasks done

Fixes 5 | Team, Task, Settings pages #734

KostyaEver opened this issue Mar 30, 2023 · 16 comments
Assignees
Labels
Tested Tested by Assignees WEB Web app
Milestone

Comments

@KostyaEver
Copy link

KostyaEver commented Mar 30, 2023

  • In Settings - there is NOT 'back' arrow and The dashboard in the page path does not work (the user should be able to go back)

  • Team page - we don't have the ‘Status’ dropdown on the user car under the title we need to add it ONLY for the Team page (on the User Task page should be without Status for each Task card)

  • User Task page / Tabs Worked & Assigned - buttons 'Start' should be in 3rd column with Time (not where the progress bar → see Figma design)

  • User Task page / Tabs Worked & Assigned & Unassigned - make wider Estimate & Time columns

  • User Task page / Tabs Worked & Assigned & Unassigned - if the user refreshes the page it should remember Tab was selected the last time (now it always refers to Worked)

  • Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

  • Team page - Labels are displayed on user cards, if user reload whole page (but need to be checked code one more time, there is some delay or something wrong)

  • If Time tracking is disabled for a user - should not see 'own Task card' on Team page and 'own Task page'

  • the Size of Status, Labels, Priorities are still bigger than task titles etc (PR)

  • When the manager deletes only team -> should see the main page without team + button 'Create team'

  • When the manager deletes team and press 'log out' should see the main landing page (Now nothing)

  • When the manager deletes own account -> should see the main landing page (Now nothing)

  • When the manager tries to 'Remove account' from all teams (within one tenant/workspace) -> should be able to remove from all teams where the user is not a manager (PR)

  • When a user has a few invites to join teams and clicks on ‘Reject’ on one of them, it should close only exactly that notification user ‘Rejected’ (Now it closes all notifications)

  • Team page / User card - Progress Bar does not display progress

  • User Task page / Task card - Progress Bar does not display progress (PR)

  • Team page / User card - the manager should be able to estimate own and other’s tasks on the user card by clicking the ‘icon’ edit (it used to work)

  • Team page / User card / ( … ) Edit Task - user should be able to see the cursor at the end of the Title text inside the input AND the whole title should be selected (it used to work)

  • Settings / Team - when the user creates a new Label - should not see the name of the previously created label and the color should be randomly selected

  • User Task page / Tabs Worked, Assigned, Unassigned - there are still tasks in the wrong tabs.
    Worked / Now - should display the active user's task
    Worked - should contain only tasks user worked on (even 1-sec worked, even no longer assigned)
    Assigned - should display all tasks user Assigned at the moment (worked, not worked)
    Unassigned - should display all tasks user is not assigned at the moment

  • Team page - users don't see each other's 'Total time worked today', 'Worked on Task' on cards (PR)

  • Team page - When the user logged in and had active task from the previous session task - should be able to start tracking time instantly (now the system asks to select the task in order to start tracking time) Solution: The system should make Active the last task user worked (PR)

  • Team page / Main input - if user does not have selected task - user can't select Status, Priority, Size, Label

  • Personal Settings - when user is not a part of any team AND 'Delete' own account, should be redirected to the main Landing page

  • Settings / Team - Public Team should be selected by default

  • Settings / Team - Public Team does not display Status, Priority, Size, Label - if user select specific (displays only default empty)

  • Settings / Personal - change email to another -> should send Code on new email (now does not send)

  • Status - we should set default status for each tasks 'First' -> 'Open'(in our case)

  • Status - when user select task with any status and start tracking the time (with automation) the status should be 'In progress' without automation - a status is set by the assignee

  • Team page - if user closes a task, it should disappear from 'user card' AND from 'the main input' (closed task should be in closed Tab) Should look like her has no task until pick one up (PR)

  • Team page / Main input - if user start typing something unique (create new task) in 3-5 sec the system erases it that is not good. Typed text should be kept until user press enter to confirm task creation OR erase if select any other task or do another action

  • Team page / ( ... ) - Remove member - user should be removed from the list of team members (now active user becomes as invited and then manages should remove again)

  • Team Avatar - it is updated every 3-5 sec - it looks terrible. We should fix it

  • Invite - when User A is part of Team A and User A sees invite from Team B inside the app, should be able to 'accept' and join (see that team in the list of User's A teams) (NOW User A does not see) [SAME TENANT WORKING]

  • Status on Avatar (green/ orange / red) - team members of newly joined users should see his/her status even they are not selected any task (green with dot OR red)

  • Progress Bar - if two or more members work on the same task, they should see the same progress bar, estimate. On live mode progress bar should move 2/3 etc times faster in dependency of how many members are currently tracking the time for the task

  • Progress Bar - on User Task page - no progress o task cards (should be displayed the latest progress)(PR)

  • Public page / Progress Bar - should be updated synchronously as for LIVE view (PR)-

  • Public page - user's avatar status should be updated right after it is changed

  • Public page - task Status, Size, Priority, Label - not always display all of them - (PR)

  • Team page - column 'Worked on Task' should be updated in LIVE mode (PR)

  • Settings - change own email to another does not send CODE Settings menu | Personal - as a user I can change email #587

  • Public page - if user presses 'Requested join' (but has an account) should select Tab 'Already Member' and with own email join and see the normal page as if the user Login from the main landing page (now the user can see Public page only)

  • Team page - on cards Titles - remove title 'Status' and Keep only 'Name' title and rest titles that we had

  • Team page / Invitation List : User should automatically see if he/she gets any new Invitation (Now user has to refresh it)

  • When an employee user Delete Account it gives a forbidden error

  • Team Avatar - still works not good

  • Team page / Unassign task from yourself - the main input should become empty (now it still shows the assigned task data)

  • Team page / Estimation input bug - since the system updates the page every 5 sec if a user enters estimate values and does not have time to save it - the browser update page and all data is lost, and input becomes empty.

  • User Task page / Filter - in order to collapse Filter if there are no selected items user should be able to click out of the Filter card

  • User Task page - The Column with status has different sizes for each status Image

  • App Crashing when the user is not part of any Team

  • SUPER_ADMIN User is not able to create a Team (PR)

  • Time Status API gives 403 error for SUPER_ADMIN

  • Task timer should be run Team wise

  • Multiple Tabs open - If in one tab timer started then it should sync automatically in another tab (Now if we refresh tab then only it sync) (PR)

  • Custom-created Labels can be seen by other teammates without reload the page

  • Team page - if a user (manager) disabled Time tracking, User task card should NOT be displayed on Team page (PR)

  • Public page does not display a team - (PR)

  • Input of Task Status, Size, Priority and Label automatically removed every 5 seconds (PR)

  • Assigned Manager can NOT 'Remove' Admin (Team Owner) Manager

  • Team page / Unassign task from yourself - the main input should become empty (now the unassigned task appears on the user card again - but not assigned until the user starts tracking time)

  • 'Start/Stop' button works not well. Sometimes when the user wants to stop the button it is not clickable and vice versa. As the additional button does not change status of the button to Stop or Play (PR)

  • Team page - Label keeps disappearing on changing Status/Size/Priority (PR)

  • Team page - Wrong Task Estimation is showing for current active task - (PR)

  • Team Settings - If user edit Team name and haven't saved yet it keeps changing to original one after every 5 seconds refresh - (PR)

  • Detect Timezone not working in Firefox

  • USER TASK PAGE - since the system updates the page every 5 sec if a user enters estimate values and does not have time to save it - the browser update page and all data is lost, and input becomes empty (PR)

  • TEAM PAGE - since the system updates the page every 5 sec if a user type values in main input and does not have time to save it - the browser update page and all data is lost (PR)

  • USER TASK PAGE - Same estimation are considered In all the Task cards - (PR)

  • - for invite card and invited user card let's use the format 0h:0m (not 00h: 00m) - (PR)

  • - Invitation, if user A is online can see the invite inside the app, when user A invited first time to Team 1 it works, if the user A was removed form the team, second time does not see an invite from the same team (PR)

  • - team settings / got an issue when I clicked 'Create new Label' (the system was thinking) then I clicked on 'Create new ..' for size, and priority and got an error. Seems like an issue with API statuses, priorities, sizes, labels creation

  • - User Task page / Worked - in the 'Now' section should be displayed only the task the user worked last time TODAY, all previous tasks the user worked on should be in that period it was. - (PR)

  • - User Task page-/ TimeTracker should work the same as on Team page (counting time speed) - NOW it works differently.

  • - Team page - Estimation input which is under the main input, there's still an issue with entering the estimate while the Time Tracker is on - (PR)

  • - User Task page / Worked - somehow user A just created task X (nobody assigned except user A) can see that task in User Task page / Worked of other teammates (even all tasks user A worked) - (PR)

  • - The invite user feature does not work for the users who were removed from the team (the second time the users can’t be invited - that is NOT good)

  • - Naming (Teams, Members) - only Letters possible in icon or avatar

  • - Manager deletes own team (gives an error) - there was one more team member, when the user refreshes the page it displays user account without team

@KostyaEver KostyaEver added the WEB Web app label Mar 30, 2023
@KostyaEver KostyaEver added this to the v0.1.0 milestone Mar 30, 2023
paradoxe35 added a commit that referenced this issue Apr 2, 2023
paradoxe35 added a commit that referenced this issue Apr 2, 2023
@evereq evereq closed this as completed in da779af Apr 2, 2023
@paradoxe35 paradoxe35 reopened this Apr 2, 2023
@badalkhatri0924
Copy link
Contributor

badalkhatri0924 commented Apr 5, 2023

@KostyaEver

Can you check Settings / Personal - change email to another -> should send Code on new email (now does not send) again? I am getting emails (Checked in stage and production both). It is fixed when we did migrations for an email template. If it is working for you now then we can close this.

Duplicate: Settings - change own email to another does not send CODE https://github.com/ever-co/ever-gauzy-teams/issues/587

@badalkhatri0924
Copy link
Contributor

badalkhatri0924 commented Apr 5, 2023

@KostyaEver @evereq

When the manager deletes only team -> should see the main page without team + button 'Create team'

Should we redirect to the main page?

Currently, when we Manager Dispose the only team we are opening Popup as shown below.
And if the manager closes the popup in the Team setting we are already showing Create new Team button.

I think it is not necessary here to redirect to main page as Team setting and Main page UI is almost same for Create new Team button.

image

image

@badalkhatri0924
Copy link
Contributor

@evereq @KostyaEver
Settings / Team - Public Team should be selected by default

In my opinion, the team should be Private by default (The current implementation is the same), Not all the users/managers will want the team to be public by default.

Let me know your thoughts on this why we need to make default Public.

@evereq evereq closed this as completed in af82d19 Apr 5, 2023
evereq added a commit that referenced this issue Apr 5, 2023
evereq added a commit that referenced this issue Apr 5, 2023
fix: #734 Close only rejected notification
@KostyaEver
Copy link
Author

@KostyaEver @evereq

When the manager deletes only team -> should see the main page without team + button 'Create team'

Should we redirect to the main page?

Currently, when we Manager Dispose the only team we are opening Popup as shown below. And if the manager closes the popup in the Team setting we are already showing Create new Team button.

I think it is not necessary here to redirect to main page as Team setting and Main page UI is almost same for Create new Team button.

image image

@badalkhatri0924
My bad, so here everything is ok, just the problem that when the user delete team and logout it does not redirect to the main landing page (Login / Create team)

@badalkhatri0924
Copy link
Contributor

@KostyaEver @evereq
When the manager deletes only team -> should see the main page without team + button 'Create team'
Should we redirect to the main page?
Currently, when we Manager Dispose the only team we are opening Popup as shown below. And if the manager closes the popup in the Team setting we are already showing Create new Team button.
I think it is not necessary here to redirect to main page as Team setting and Main page UI is almost same for Create new Team button.
image
image

@badalkhatri0924 My bad, so here everything is ok, just the problem that when the user delete team and logout it does not redirect to the main landing page (Login / Create team)

I've fixed this today @KostyaEver.

@paradoxe35
Copy link
Contributor

paradoxe35 commented Apr 9, 2023

Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

@badalkhatri0924
we need an API to upload a custom task status icon

@badalkhatri0924
Copy link
Contributor

Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

@badalkhatri0924 we need an API to upload a custom task status icon

@paradoxe35 @KostyaEver I think custom icon upload we aren't doing in v1.
@KostyaEver As I remember we decided that we might be using some libraries to show available icons.

@evereq evereq closed this as completed in bef6704 May 2, 2023
evereq added a commit that referenced this issue May 2, 2023
fix: #734 Updated dynamic estimation for user task card
badalkhatri0924 added a commit that referenced this issue May 5, 2023
@evereq evereq closed this as completed in d8a6673 May 8, 2023
evereq added a commit that referenced this issue May 8, 2023
fix: #734 Refresh token on user accept invitation to new Team
evereq added a commit that referenced this issue May 8, 2023
badalkhatri0924 added a commit that referenced this issue May 9, 2023
badalkhatri0924 added a commit that referenced this issue May 9, 2023
@evereq evereq closed this as completed in 712e104 May 9, 2023
evereq added a commit that referenced this issue May 9, 2023
evereq added a commit that referenced this issue May 9, 2023
@evereq evereq closed this as completed in 20e3eb8 May 9, 2023
evereq added a commit that referenced this issue May 9, 2023
fix: #734 Showing NOW section only when user is tracking time
evereq added a commit that referenced this issue May 14, 2023
fix:#734 Worked tab tasks filtered as per current user
@badalkhatri0924 badalkhatri0924 added the Tested Tested by Assignees label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested Tested by Assignees WEB Web app
Projects
Status: Done
Development

No branches or pull requests

4 participants