Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add manual time popup page #2715

Merged
merged 20 commits into from
Jul 17, 2024
Merged

[Feature] Add manual time popup page #2715

merged 20 commits into from
Jul 17, 2024

Conversation

GedeonTS
Copy link
Contributor

@GedeonTS GedeonTS commented Jul 12, 2024

[

clideo_editor_b6fd0993fbf74194844bd4e848288b1e.1.mp4

](url)

@GedeonTS GedeonTS linked an issue Jul 12, 2024 that may be closed by this pull request
@Cedric921
Copy link
Member

Is it possible to attach a video showing how it works?
@GedeonTS

@Cedric921 Cedric921 added this to the v0.2.0 milestone Jul 12, 2024
@evereq evereq requested a review from Cedric921 July 12, 2024 17:00
Copy link
Member

@Cedric921 Cedric921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just put the PR in draft while you finish the updates I proposed in Slack
@GedeonTS
CC: @evereq

@Cedric921 Cedric921 marked this pull request as draft July 12, 2024 21:11
@GedeonTS GedeonTS marked this pull request as ready for review July 14, 2024 23:03
@GedeonTS GedeonTS marked this pull request as draft July 16, 2024 09:52
@evereq
Copy link
Member

evereq commented Jul 17, 2024

@GedeonTS fix merge conflict please. If need help, ask @GloireMutaliko21

@evereq
Copy link
Member

evereq commented Jul 17, 2024

@GedeonTS I don't get it, why you added https://github.com/catc/react-timekeeper package!? It's not supported for 3+ years!

@GedeonTS
Copy link
Contributor Author

Hi @evereq , @Cedric921 I have fixed the conflict and also removed the TimeKeeper package.

@evereq evereq merged commit ba9477c into develop Jul 17, 2024
11 of 12 checks passed
@evereq evereq deleted the add_task_time branch July 17, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Manual Time | 'Add manual time' popup/page
3 participants